fix(DB): align creature spawns with new id column - #7
Conversation
Core PR azerothcore/azerothcore-wotlk#25197 renamed creature.id1 to id and dropped the id2/id3 columns into the new creature_multispawn table. All spawns in this module used 0 for id2/id3, so the column list and VALUES rows are updated to the new schema and the DELETE/UPDATE filters now reference id instead of id1. References azerothcore/azerothcore-wotlk#25197
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughTwo SQL update scripts ( Changescreature.id Column Migration
War Event gameobject Rotation Adjustments
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
With the creature SQL now importing cleanly, the worldserver starts far enough to surface two pre-existing data issues that the old failing import hid: - The module deletes core's AQ War Effort NPCs (game_event 22) by entry and respawns them permanently, leaving the matching game_event_creature rows pointing at deleted guids. Drop those references before deleting the creatures. - The replacement gong gameobjects stored a zero (non-unit) rotation quaternion. Set the proper Z-axis quaternion derived from each orientation so the loader stops logging an error.
Aligns the module SQL with core PR azerothcore/azerothcore-wotlk#25197, which renamed
creature.id1tocreature.idand moved the rarely usedid2/id3columns into the newcreature_multispawntable.All creature spawns in this module used
0forid2/id3, so there is nothing to migrate intocreature_multispawn. The changes are:(`guid`, `id1`, `id2`, `id3`, ...)to(`guid`, `id`, ...).0,0fields forid2/id3.DELETE/UPDATEfilters now use`id`instead of`id1`.Mirrors the same alignment done in lightninjay/mod-tcg-vendors#8.
Summary by CodeRabbit