fix: repair backends E2E baseline regressions from PR #520 (INT-1254) - #556
Open
AlexanderZ-Band wants to merge 1 commit into
Open
fix: repair backends E2E baseline regressions from PR #520 (INT-1254)#556AlexanderZ-Band wants to merge 1 commit into
AlexanderZ-Band wants to merge 1 commit into
Conversation
…on (INT-1254) PR #520 made an unsupported emit kind raise BandConfigError at construction instead of a lazy on_started warning, surfacing two latent gaps in the E2E baseline suite. CopilotACPAdapter declares SUPPORTED_EMIT = frozenset() by design -- its ACP tool narration is unconditional, never emit-gated -- but the shared memory_features()/contacts_features() matrix fixtures hardcode emit={Emit.TOOL_CALLS} for every adapter under test. Clamp the requested emit to CopilotACPAdapter.SUPPORTED_EMIT in its builder so the fixture's intent (observable tool calls) survives without tripping the new construction-time check. test_codex_thoughts_are_not_placeholders still used the retired features=AdapterFeatures(...) constructor pattern PR #520 removed; switch it to the direct emit= kwarg. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JieRNYtYxMPfLkMqHgbXvT
AlexanderZ-Band
enabled auto-merge
August 21, 2026 07:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CopilotACPAdapterdeclaresSUPPORTED_EMIT = frozenset()by design (ACP tool narration is unconditional, never emit-gated), but the sharedmemory_features()/contacts_features()capability-matrix fixtures hardcodeemit={Emit.TOOL_CALLS}for every adapter. PR feat!: cohesive adapter construction surface (INT-1166) #520 turned an unsupported-emit request from a lazyon_startedwarning into a construction-timeBandConfigError, so every copilot_acp memory/contacts matrix cell now fails at fixture setup.test_codex_thoughts_are_not_placeholdersstill built its adapter via the retiredfeatures=AdapterFeatures(emit={Emit.THOUGHTS})pattern PR feat!: cohesive adapter construction surface (INT-1166) #520 removed, raisingTypeError: SimpleAdapter._resolve_features() got an unexpected keyword argument 'features'._build_copilot_acpnow clamps the requestedemittoCopilotACPAdapter.SUPPORTED_EMITbefore construction, and the codex smoke uses the directemit=Emit.THOUGHTSkwarg.Fixes the 4 nightly baseline failures from run 32443980372 (commit 1ca53ba):
test_store_memory_across_memory_adapters[copilot_acp],test_recall_memory_across_memory_adapters[copilot_acp],test_memory_survives_adapter_rehydration[copilot_acp],test_list_contacts_across_contacts_adapters[copilot_acp]; plustest_codex.py::test_codex_thoughts_are_not_placeholders.Test-only change —
src/banduntouched; the stricter construction-time validation from PR #520 is correct and stays as-is.Linear: INT-1254
Test plan
uv run ruff check/uv run ruff format --checkon changed filesuv run pyrefly check— 0 errorsuv run pytest tests/ --ignore=tests/integration/ --ignore=tests/e2e/ -q— 4874 passed, 122 skippedCopilotACPAdapter/CodexAdapterno longer raiseBandConfigError/TypeErrorwith the fixed buildersBAND_E2E_LANE=backends) to confirm the 5 tests pass against the real platform + Copilot/Codex CLIs (needs live credentials, not run in this session)🤖 Generated with Claude Code
https://claude.ai/code/session_01JieRNYtYxMPfLkMqHgbXvT