Skip to content

fix: repair backends E2E baseline regressions from PR #520 (INT-1254) #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexanderZ-Band wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −3
Open

fix: repair backends E2E baseline regressions from PR #520 (INT-1254) #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/e2e/baseline/smoke/adapters/test_codex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import pytest

from band.adapters.codex import CodexAdapter, CodexAdapterConfig
from band.core.types import AdapterFeatures, Emit
from band.core.types import Emit

from tests.e2e.baseline.agents import Lane, lane
from tests.e2e.baseline.flaky import flaky_infra
Expand Down Expand Up @@ -72,7 +72,7 @@ async def test_codex_thoughts_are_not_placeholders(
config_kwargs["reasoning_summary"] = "auto"
adapter = CodexAdapter(
config=CodexAdapterConfig(**config_kwargs),
features=AdapterFeatures(emit={Emit.THOUGHTS}),
emit=Emit.THOUGHTS,
)

identity = await resource_manager.provision_agent("codex-thoughts")
Expand Down
12 changes: 11 additions & 1 deletion tests/e2e/baseline/toolkit/builders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,10 +466,20 @@ def _build_copilot_acp(
if s.backends.copilot_command.strip():
config_kwargs["command"] = tuple(s.backends.copilot_command.split())

built_features = feature_kwargs(features)
if "emit" in built_features:
# memory_features()/contacts_features() request Emit.TOOL_CALLS so tool
# calls surface as tool_call events for the rest of the matrix, but this
# adapter narrates every tool call unconditionally and declares no
# SUPPORTED_EMIT (see ACPClientAdapter) -- clamp to what it actually
# supports so the shared fixture's intent survives without tripping the
# construction-time unsupported-emit check.
built_features["emit"] &= CopilotACPAdapter.SUPPORTED_EMIT

return CopilotACPAdapter(
config=CopilotACPAdapterConfig(**config_kwargs),
additional_tools=_custom_tool_defs(tools),
**feature_kwargs(features),
**built_features,
)


Expand Down
Loading