fix: reject malformed payment amount strings#367
Open
realmehmetali wants to merge 1 commit into
Open
Conversation
Collaborator
🟡 Heimdall Review Status
|
realmehmetali
marked this pull request as ready for review
July 18, 2026 14:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseFloatvalidation with strict decimal-string validationRoot cause
parseFloataccepts a valid numeric prefix and ignores trailing invalid characters. Values such as1abcand1.2.3could therefore pass initial validation and fail later during transaction encoding.Agent impact
At the AI-agent frontier, tool-generated payment inputs must fail closed. Strict decimal validation prevents malformed model output from reaching transaction encoding or producing ambiguous payment failures.
Fixes #313.
Validation
AI assistance
Codex assisted with implementation and regression-test preparation. I reviewed the public issue, surrounding validation behavior, test results, and final diff before submission.