Skip to content

fix: reject malformed payment amount strings #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
realmehmetali wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: reject malformed payment amount strings #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/account-sdk/src/interface/payment/utils/validation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,25 @@ describe('validateStringAmount', () => {

it('should reject invalid amounts', () => {
expect(() => validateStringAmount('0', 6)).toThrow('Invalid amount: must be greater than 0');
expect(() => validateStringAmount('00.000000', 6)).toThrow(
'Invalid amount: must be greater than 0'
);
expect(() => validateStringAmount('-10', 6)).toThrow('Invalid amount: must be greater than 0');
expect(() => validateStringAmount('abc', 6)).toThrow('Invalid amount: must be a valid number');
expect(() => validateStringAmount('10.1234567', 6)).toThrow(
'Invalid amount: pay only supports up to 6 decimal places'
);
});

it.each(['1abc', '1foo', '1.2.3', '1e6', '1.', '.1', '.', '', ' 1', '1 ', 'Infinity'])(
'should reject malformed amount %s',
(amount) => {
expect(() => validateStringAmount(amount, 6)).toThrow(
'Invalid amount: must be a valid number'
);
}
);

it('should reject non-string amounts', () => {
expect(() => validateStringAmount(10 as any, 6)).toThrow('Invalid amount: must be a string');
});
Expand Down
6 changes: 2 additions & 4 deletions packages/account-sdk/src/interface/payment/utils/validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,11 @@ export function validateStringAmount(amount: string, maxDecimals: number): void
throw new Error('Invalid amount: must be a string');
}

const numAmount = parseFloat(amount);

if (isNaN(numAmount)) {
if (!/^-?\d+(?:\.\d+)?$/.test(amount)) {
throw new Error('Invalid amount: must be a valid number');
}

if (numAmount <= 0) {
if (amount.startsWith('-') || !/[1-9]/.test(amount)) {
throw new Error('Invalid amount: must be greater than 0');
}

Expand Down