Use virsh nwfilter-define to reload filters#16
Merged
bborbe merged 4 commits intobborbe:masterfrom Feb 22, 2026
Merged
Conversation
When nwfilter XML files change, trigger virsh nwfilter-define to reload them. This avoids perpetual diffs caused by libvirt adding UUID/comments to the files.
bborbe
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix perpetual diffs on nwfilter XML files.
Problem: libvirt adds UUID/comments/reorders attributes when it loads filters, causing BW to see diffs even though the filters are functionally identical.
Solution: Trigger
virsh nwfilter-definewhen the source template changes. This lets libvirt format the on-disk XML however it wants.After this PR merges,
bw apply hm.nukewill be clean - no more nwfilter prompts.