Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Please choose versions by [Semantic Versioning](http://semver.org/).

## Unreleased
- Update nwfilter configuration to use explicit rule-based format for better clarity
- Fix nwfilter reload to preserve UUID and avoid libvirt format drift

## v0.3.5
- Fix CI test failures by ignoring missing vault faults
Expand Down
23 changes: 21 additions & 2 deletions bundles/kvm-host/items.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
svc_systemd = {}
directories = {}
symlinks = {}
actions = {}

if node.metadata.get('kvm-host', {}).get('enabled', False):
svc_systemd['libvirtd'] = {
Expand Down Expand Up @@ -45,17 +46,35 @@
}

# nwfilter support for VM network restrictions
directories['/etc/bundlewrap/nwfilter'] = {
'owner': 'root',
'group': 'root',
'mode': '0755',
}

for vm_name, filter_config in node.metadata.get('kvm-host', {}).get('nwfilters', {}).items():
filter_name = f'restrict-{vm_name}'

files[f'/etc/libvirt/nwfilter/{filter_name}.xml'] = {
# Store our template in bundlewrap directory (not libvirt's)
files[f'/etc/bundlewrap/nwfilter/{filter_name}.xml'] = {
'source': 'nwfilter.xml',
'content_type': 'mako',
'mode': '0600',
'mode': '0644',
'owner': 'root',
'group': 'root',
'context': {
'filter_name': filter_name,
'rules': filter_config.get('rules', []),
},
'triggers': [f'action:nwfilter_reload_{filter_name}'],
}

# Only define if different from current
actions[f'nwfilter_reload_{filter_name}'] = {
'command': (
f'UUID=$(virsh nwfilter-dumpxml {filter_name} 2>/dev/null | grep -oP "(?<=<uuid>)[^<]+") && '
f'sed "1 a\\ <uuid>$UUID</uuid>" /etc/bundlewrap/nwfilter/{filter_name}.xml | virsh nwfilter-define /dev/stdin || '
f'virsh nwfilter-define /etc/bundlewrap/nwfilter/{filter_name}.xml'
),
'triggered': True,
}
3 changes: 0 additions & 3 deletions nodes/hm.nuke.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@
'devices': ['/dev/nvme0n1', '/dev/nvme1n1', '/dev/nvme2n1', '/dev/nvme3n1'],
}
},
'monit': {
'test_alert': True,
},
'msmtp': {
'enabled': True,
'host': '172.16.90.1',
Expand Down