Harmonize CellNames_scseqCMs6 signatures with malignant nomenclature … - #390
Merged
Merged
Conversation
…388/#389) PRs #388/#389 harmonized the malignant annotation in CellTypes_v1.tsv, removing the melanoma/colorectal child cell types and keeping only the 'malignant cell' (short_dblabel 'Malignant') parent. The CellNames_scseqCMs6 signature datasets still referenced the removed terms, leaving besca internally inconsistent (obtain_new_label raised "Error trying to reach MelMelanoma in nomenclature"). - Merge MelMelanoma + ColorectalCancer signatures into a single 'Malignant' signature (union of marker genes) in config + sigs, human + mouse. - Rename 'Microglia' -> 'Microglial' to match the existing nomenclature short_dblabel 'microglial cell' (pre-existing typo). Every CellNames_scseqCMs6 config term / signature name now resolves to a short_dblabel in CellTypes_v1.tsv. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…(#388/#389)
PRs #388/#389 harmonized the malignant annotation in CellTypes_v1.tsv, removing the melanoma/colorectal child cell types and keeping only the 'malignant cell' (short_dblabel 'Malignant') parent. The CellNames_scseqCMs6 signature datasets still referenced the removed terms, leaving besca internally inconsistent (obtain_new_label raised "Error trying to reach MelMelanoma in nomenclature").
Every CellNames_scseqCMs6 config term / signature name now resolves to a short_dblabel in CellTypes_v1.tsv.