test(ci): add native hosted smoke checks - #89
ben-ranford wants to merge 3 commits into
Conversation
ben-ranford
added
area:runtime
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e14c62884
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
🟡 Changes recommended
Add Unicode-input coverage to the native smoke selection.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds bounded macOS and Windows hosted smoke checks with JSON test accounting, runner safeguards, documentation, and inventory updates.
Changes:
- Adds pinned native smoke jobs and runner allowlist entries.
- Adds smoke selection and test-event validation.
- Updates tests, generated inventory, and documentation.
File summaries
| File | Description |
|---|---|
scripts/rigor/workflow-guard/main.go |
Updates native runner allowlisting. |
scripts/rigor/workflow-guard/main_test.go |
Tests runner restrictions. |
scripts/rigor/native-smoke/main.go |
Runs and accounts for selected smoke tests. |
scripts/rigor/native-smoke/main_test.go |
Tests smoke event accounting. |
scripts/rigor/generated/dependency-inventory.json |
Updates generated dependency data. |
docs/README.md |
Links native smoke documentation. |
docs/native-hosted-smokes.md |
Documents coverage and budgets. |
.github/workflows/ci.yml |
Adds macOS and Windows smoke jobs. |
Review details
- Files reviewed: 7/8 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
3a07475 to
42ebce5
Compare
|
Sonar API auditReviewed commit: Live public SonarCloud API queries for PR #89 returned:
Audited via CLI at 2026-09-14T13:04:56.752554+00:00. Project visibility was verified as public. No findings were changed or suppressed. |
Summary
Closes #59.
go test -jsonsmoke harness that fails if the command fails or any selected root test has no completedpassevent; selected skips and failures also fail the harness.ci.yml.Scope firewall
A review item is in scope only when it directly prevents #59 acceptance and is an incremental correction in
.github/workflows/ci.yml,scripts/rigor/native-smoke, the workflow guard, generated inventories, or native-smoke documentation. Sharing a file with this change is not sufficient.Validation
go run ./scripts/rigor/native-smokego test ./scripts/rigor/native-smoke -count=1(cd scripts/rigor/workflow-guard && go test ./... -count=1)make workflow-validatemake dependency-inventory license-inventorygit diff --checkmake ci(completed through the release-contract target after regenerating the dependency inventory for the new standard-library-only smoke package)The updated head requires fresh hosted macOS and Windows smoke results before merge. Local smoke execution passes all 10 selected tests; it does not substitute for those native hosted checks.
Release Notes
Adds CI-only macOS and Windows hosted smoke coverage. There is no public API, protocol, or release behavior change.