chore(release): prepare held 1.1 Release Please PR - #95
ben-ranford wants to merge 5 commits into
Conversation
ben-ranford
added
rigor-uplift
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🔵 Needs a closer look
Align stable manifest validation with supported release-tag build metadata.
Pull request overview
Prepares Release Please for stable 1.1.0 versioning while retaining the RC2 manifest and release gates.
Changes:
- Removes RC-specific Release Please settings.
- Expands release-contract tests for stable versions.
- Updates release documentation for the held target.
The stable contract still rejects build metadata accepted by the release-tag validator and requires alignment.
File summaries
| File | Description |
|---|---|
requirements/release_please_test.go |
Updates configuration and version-contract tests. |
release-please-config.json |
Removes prerelease-specific settings. |
README.md |
Documents the held release target. |
docs/client-adoption.md |
Updates adoption guidance for the held target. |
Review details
Suppressed comments (1)
requirements/release_please_test.go:13
- Now that this contract accepts stable versions, it still rejects
1.0.0+build.7, even though the repository's release-tag validator accepts GA tags with build metadata (scripts/rigor/check-release-tag.sh:5-24andscripts/rigor/cmd/rigor/release_tag_test.go:19-24). A valid tagged manifest can therefore failTestRootReleasePleaseConfiguration; extend the stable branch to accept SemVer build metadata and add a matching case, or align the tag validator and manifest contract deliberately.
var releaseVersion = regexp.MustCompile(`^(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)(-rc\.([1-9][0-9]*))?$`)
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Fixed the suppressed stable build-metadata manifest contract finding in f23eac4. Stable 1.0.0+build.7 is accepted; empty and malformed metadata are rejected. Existing RC contract and genuine RC2 manifest remain unchanged. Requirements tests and full make ci pass; the final generated release PR remains reserved for user approval. |
Remove RC-only Release Please configuration while preserving the released rc.2 manifest and no-publication workflow path. The final squash commit must retain this one-shot footer so Release Please prepares the held 1.1.0 approval PR. Release-As: 1.1.0
f23eac4 to
2a3d727
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a3d727ec9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de6560214e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8272a27dfe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Summary
1.0.0-rc.2manifest, make the release contract transition-safe, and describe the annotated version as a held target awaiting its tag gate.Validation
go test ./requirements -run 'Test(RootReleasePleaseConfiguration|ReleaseVersionContract)$' -count=1go vet ./requirementsmake cigit diff --checkScope firewall
This PR only prepares issue #86’s Release Please stable-version configuration and transition-safe documentation/contracts. Merge it after the implementation train. The generated version PR stays open and unarmed for user approval; no version manifest is fabricated and no release is published here.
Release Notes
Release-As: 1.1.0. This preparation PR does not arm a queue or create a tag, GitHub Release, or assets.Closes #86
Release-As: 1.1.0