Skip to content

fix: do not ignore first arg#3

Merged
GregoryAlbouy merged 1 commit intomainfrom
fix/ignored-cli-options
Oct 9, 2022
Merged

fix: do not ignore first arg#3
GregoryAlbouy merged 1 commit intomainfrom
fix/ignored-cli-options

Conversation

@GregoryAlbouy
Copy link
Member

Description

Previously the first arg was the command "run" in cmdRun context, but that changed in #1 so it needed an update.

Changes

Notes

Previously the first arg was the command "run" in cmdRun context,
but that changed so it needed an update.
@GregoryAlbouy GregoryAlbouy added the bug Something isn't working label Oct 9, 2022
Copy link
Member

@moreirathomas moreirathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah shiftArgs does that already !

@codecov-commenter
Copy link

Codecov Report

Merging #3 (1bfebba) into main (d5cb626) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage   60.49%   60.49%           
=======================================
  Files          13       13           
  Lines         281      281           
=======================================
  Hits          170      170           
  Misses        103      103           
  Partials        8        8           
Flag Coverage Δ
unittests 60.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@c1-ra c1-ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GregoryAlbouy GregoryAlbouy merged commit 624a116 into main Oct 9, 2022
@moreirathomas moreirathomas deleted the fix/ignored-cli-options branch October 9, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants