Skip to content

fix: do not ignore first arg #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GregoryAlbouy merged 1 commit into from
Oct 9, 2022
Merged

fix: do not ignore first arg #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions cmd/benchttp/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,8 @@ func (cmd *cmdRun) execute(args []string) error {
// parseArgs parses input args as config fields and returns
// a slice of fields that were set by the user.
func (cmd *cmdRun) parseArgs(args []string) []string {
// first arg is subcommand "run"
// skip parsing if no flags are provided
if len(args) <= 1 {
if len(args) == 0 {
return []string{}
}

Expand All @@ -88,7 +87,7 @@ func (cmd *cmdRun) parseArgs(args []string) []string {
// and bind their value to the config struct
configflag.Bind(cmd.flagset, &cmd.config)

cmd.flagset.Parse(args[1:]) //nolint:errcheck // never occurs due to flag.ExitOnError
cmd.flagset.Parse(args) //nolint:errcheck // never occurs due to flag.ExitOnError

return configflag.Which(cmd.flagset)
}
Expand Down