Merged
Conversation
GregoryAlbouy
added
nice to have
This was referenced Jul 31, 2022
GregoryAlbouy
force-pushed
the
refactor/config
branch
from
641ab7d to
be174e3
Compare
GregoryAlbouy
added
must have
Codecov Report
@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 73.35% 73.88% +0.52%
==========================================
Files 27 28 +1
Lines 867 873 +6
==========================================
+ Hits 636 645 +9
+ Misses 205 203 -2
+ Partials 26 25 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
GregoryAlbouy
force-pushed
the
refactor/config
branch
from
be174e3 to
34d21e7
Compare
GregoryAlbouy
force-pushed
the
chore/extract-cli-app
branch
from
75a6598 to
5dad955
Compare
GregoryAlbouy
force-pushed
the
refactor/config
branch
3 times, most recently
from
6a17c5f to
55bcf64
Compare
Member
moreirathomas
left a comment
moreirathomas
left a comment
There was a problem hiding this comment.
Finally made it ! Great work 😄
I have some suggestions for more explicit (?) names.
Member
moreirathomas
left a comment
moreirathomas
left a comment
There was a problem hiding this comment.
After reading through benchttp/cli#1, isn't Config.Output.Silence deprecated in the scope of this pr and should be remove?
Member
Author
Already done, forgot to push 🙃 |
moreirathomas
approved these changes
Oct 8, 2022
Integrate the fields memorizing logics into runner.Config - implement Config.WithFields - update tests accordingly - configparse: remove parsedConfig intermediary
- ./internal/configparse -> ./configparse
- rename nesParsedConfig -> ParseRepresentation
- prev.Override(next) -> next.Override(prev)
We cannot rely on reflect.DeepEqual anymore as private field config.fieldsSet can vary for 2 identical configs. - implement Config.Equal that ignores Config.fieldsSet - write unit tests for Config.Equal - use Config.Equal in tests
- improve documentation of Config.Override - rename Config.fieldsSet -> Config.assignedFields - refactor Config.WithFields
GregoryAlbouy
force-pushed
the
refactor/config
branch
from
e549995 to
c733c2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR follows #48 (extraction of CLI app from this repo).
Here we expose
configparseas an external package, so it can be used by the newly standalone CLI app.Some improvements around Config came in the process (see commits for details)
Changes
Linked issues
Notes