feat: import CLI app from benchttp/engine#1
Merged
GregoryAlbouy merged 12 commits intomainfrom Oct 8, 2022
Merged
Conversation
Some package renamings made sense: - configparse -> configfile - configflags -> configflag
- move runner.Report rendering from engine to cli - gather rendering in new package internal/render - move package ansi into internal/render
- fix flag -silent that was ignored - always print test suite results, even if silent is enabled - necessary step: separate summary and test suite resutlts outputs
- remove json/yaml parsing logics - use engine/configparse instead - use new method config.WithField - apply inversion of Config.Override - run go mod tidy
- use -silent as a separate CLI-only flag (same as -configFile) - update tests & fixtures accordingly - update docs accordingly
GregoryAlbouy
force-pushed
the
feat/import-cli-from-benchttp-engine
branch
from
af8071a to
998bc77
Compare
moreirathomas
previously approved these changes
Oct 8, 2022
Member
moreirathomas
left a comment
moreirathomas
left a comment
There was a problem hiding this comment.
Very very nice !
I did'nt test manually yet and will do, but it looks great !
cmd/benchttp/main.go
Outdated
| } | ||
|
|
||
| func run() error { | ||
| commandName, nextArgs, err := shiftArgs(os.Args[1:]) |
Member
There was a problem hiding this comment.
Nitpick :
Suggested change
| commandName, nextArgs, err := shiftArgs(os.Args[1:]) | |
| command, options, err := shiftArgs(os.Args[1:]) |
to mirror the ofter used syntax
program-example [command] <options>
Member
Author
There was a problem hiding this comment.
Done, except for command that conflicts with type command interface below
moreirathomas
approved these changes
Oct 8, 2022
This reverts commit dfc1413.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extract CLI app from benchttp/engine to make it a standalone repository.
Must be merged after the following PRs:
Then we can delete the temporary commit which will fix the CI.
Changes
Notes