Repository navigation
fix(api-sync): fetch delivery artifacts to /tmp, not the repo tree - #73
Merged
Merged
Conversation
The api-sync workflow wrote spec-current.json and delivery.json into .api-sync/ before running the patcher, so the sync commit's git add -A swept delivery.json into the committed tree (#72). Biome's formatter diff on that file then failed lint on main, blocking the Main workflow. Fetch both files to /tmp/api-sync instead and point the manifest verification and the patcher's --spec flag there, so the committed tree only ever gains patcher-made source changes plus the refreshed spec-snapshot.json. Also drop the already-committed delivery.json from main and gitignore both paths as a belt-and-braces guard. Claude-Session: https://claude.ai/code/session_01F1stiNzuNtJXoXtiW9ZCbs
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.api-sync/spec-current.jsonand.api-sync/delivery.jsoninto the repo tree before running the patcher, so the sync commit'sgit add -Asweptdelivery.jsoninto feat: sync SDK with API changes (v5.3.0) #72 (merged as part of v5.3.0).delivery.jsonthen fails lint on main, which blocks the Main workflow (lint gates type-checking, tests and snyk vianeeds).Fix
.github/workflows/api-sync.yml: fetch both delivered files to/tmp/api-sync/instead of.api-sync/, and point the manifest verification and the patcher's--specflag at that path. The committed tree now only ever gains patcher-made source changes plus the refreshedspec-snapshot.json..api-sync/delivery.jsonfrom main..api-sync/delivery.jsonto.gitignorealongside the existingspec-current.jsonentry, as a belt-and-braces guard.Test plan
bun installbun run lint:checkpasses (only 3 pre-existing warnings, unrelated to this change)bun run sync:checkpasses with no pending driftbun run testhas 2 pre-existing failures (CreateInstanceRfiBodyschema mismatch) that reproduce identically on main without this diff, confirmed unrelated to this fixhttps://claude.ai/code/session_01F1stiNzuNtJXoXtiW9ZCbs