Skip to content

fix(api-sync): fetch delivery artifacts to /tmp, not the repo tree #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericviana merged 1 commit into from
Aug 4, 2026
Merged

fix(api-sync): fetch delivery artifacts to /tmp, not the repo tree #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .api-sync/delivery.json
View file
Open in desktop

This file was deleted.

14 changes: 7 additions & 7 deletions .github/workflows/api-sync.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,19 @@ jobs:
run: |
set -e
git fetch origin api-sync-data
mkdir -p .api-sync
mkdir -p /tmp/api-sync

if ! git show origin/api-sync-data:.api-sync/spec-current.json > .api-sync/spec-current.json; then
if ! git show origin/api-sync-data:.api-sync/spec-current.json > /tmp/api-sync/spec-current.json; then
echo "::error::.api-sync/spec-current.json is missing on the api-sync-data branch."
exit 1
fi
if ! git show origin/api-sync-data:.api-sync/delivery.json > .api-sync/delivery.json; then
if ! git show origin/api-sync-data:.api-sync/delivery.json > /tmp/api-sync/delivery.json; then
echo "::error::.api-sync/delivery.json is missing on the api-sync-data branch."
exit 1
fi

MANIFEST_SHA256=$(jq -r '.spec_sha256' .api-sync/delivery.json)
ACTUAL_SHA256=$(sha256sum .api-sync/spec-current.json | cut -d' ' -f1)
MANIFEST_SHA256=$(jq -r '.spec_sha256' /tmp/api-sync/delivery.json)
ACTUAL_SHA256=$(sha256sum /tmp/api-sync/spec-current.json | cut -d' ' -f1)
if [ "$MANIFEST_SHA256" != "$ACTUAL_SHA256" ]; then
echo "::error::spec-current.json sha256 ($ACTUAL_SHA256) does not match delivery.json's spec_sha256 ($MANIFEST_SHA256)."
exit 1
Expand All @@ -54,7 +54,7 @@ jobs:
fi

echo "Verified spec-current.json (sha256 $ACTUAL_SHA256) against delivery.json:"
jq -r '" source_repository: \(.source_repository)\n source_sha: \(.source_sha)\n generated_at: \(.generated_at)"' .api-sync/delivery.json
jq -r '" source_repository: \(.source_repository)\n source_sha: \(.source_sha)\n generated_at: \(.generated_at)"' /tmp/api-sync/delivery.json

- name: Check for existing api-sync PR
id: check-pr
Expand Down Expand Up @@ -93,7 +93,7 @@ jobs:
id: sync
run: |
set +e
bun scripts/api-sync/index.ts --apply --spec .api-sync/spec-current.json --report /tmp/sync-report.json
bun scripts/api-sync/index.ts --apply --spec /tmp/api-sync/spec-current.json --report /tmp/sync-report.json
echo "exit_code=$?" >> "$GITHUB_OUTPUT"
set -e
echo "bump=$(jq -r '.bump' /tmp/sync-report.json)" >> "$GITHUB_OUTPUT"
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,4 @@ dist

# api-sync: delivered fresh each CI run from the api-sync-data branch, never committed
.api-sync/spec-current.json
.api-sync/delivery.json
Loading