Repository navigation
fix(api-sync): default --check to the committed snapshot - #41
Merged
Merged
Conversation
…rrent spec-current.json only exists on the api-sync-data branch, so a bare --check on a fresh clone of main failed on a missing file. Mirrors the node patcher's defaulting: apply reads spec-current, everything else asserts against the committed snapshot. Claude-Session: https://claude.ai/code/session_01F1stiNzuNtJXoXtiW9ZCbs
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bare
php scripts/api-sync.php --checkon a fresh clone of main failed with a missing-file error because the default spec path isspec-current.json, which only exists on theapi-sync-databranch. CI was unaffected (it passes--specexplicitly); this only bit local runs. Non-apply modes now default to the committedspec-snapshot.json, mirroring the node patcher.No behavior change for
--applyor any invocation that passes--spec.https://claude.ai/code/session_01F1stiNzuNtJXoXtiW9ZCbs