Skip to content

fix(api-sync): default --check to the committed snapshot #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericviana merged 1 commit into from
Aug 4, 2026
Merged

fix(api-sync): default --check to the committed snapshot #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/api-sync.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2098,7 +2098,10 @@ function runCli(array $argv, string $root): void
$mode = $opts['apply'] ? 'apply' : 'check';
// Resolved and validated once, right where they enter the program (see resolveReadablePath()/
// resolveWritablePath() above), not re-trusted as raw strings at each later read/write.
$specPath = resolveReadablePath($opts['spec'] ?? ($root.'/.api-sync/spec-current.json'), '--spec');
// Non-apply modes assert against committed state, so the snapshot is the right
// default: spec-current.json only exists on the api-sync-data branch.
$defaultSpec = $mode === 'apply' ? '/.api-sync/spec-current.json' : '/.api-sync/spec-snapshot.json';
$specPath = resolveReadablePath($opts['spec'] ?? ($root.$defaultSpec), '--spec');
$reportPath = $opts['report'] !== null ? resolveWritablePath($opts['report'], '--report') : null;

$map = loadJson($root.'/.api-sync/spec-map.json');
Expand Down
Loading