fix(ci): merge the release PR from the push-triggered job - #60
Merged
Merged
Conversation
A pull_request-triggered workflow cannot merge release-please's PR: GitHub holds runs on bot-authored PRs as action_required, and it never starts CI on a PR the GITHUB_TOKEN opened, so an auto-merge that waits for checks waits forever. Release 3.1.0 stalled on exactly this. Claude-Session: https://claude.ai/code/session_01F1stiNzuNtJXoXtiW9ZCbs
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release-auto-merge workflow added in #58 does not work, and I found out the honest way: release 3.1.0 opened its release PR (#59) and then sat there. I merged that one by hand.
Two GitHub behaviors defeat the
pull_request-triggered approach:action_required, waiting for a human to approve it. The run for chore(main): release 3.1.0 #59 shows exactly that, so the auto-merge step never executed.GITHUB_TOKEN, so release PRs never get CI. An auto-merge that waits for required checks would therefore wait forever.So the merge now happens in
publish.yaml, in the same push-triggered job that runs release-please. It looks for an open PR labeledautorelease: pendingauthored by a bot and squash-merges it. If there is none, it is a no-op.No loop: merging the release PR pushes to main, which runs this workflow again, and that run produces the GitHub release plus the PyPI publish. At that point there is no pending release PR, so the merge step no-ops.
Also removes the now-dead
release-auto-merge.yamlrather than leaving a workflow that can never run.Verified:
yaml.safe_loadparses the file and the job's step list is as intended. The real proof is the next release, which should go from a merged sync PR to PyPI with nobody clicking.https://claude.ai/code/session_01F1stiNzuNtJXoXtiW9ZCbs