Skip to content

Add missing identifiers for commonly used flight controllers #3884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaojulong wants to merge 1 commit into from
Closed

Add missing identifiers for commonly used flight controllers #3884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/services/ardupilot_manager/flight_controller_detector/board_identification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ class SerialBoardIdentifier(BaseModel):
SerialBoardIdentifier(attribute=SerialAttr.product, id_value="FMU v3.x", platform=Platform.Pixhawk1),
SerialBoardIdentifier(attribute=SerialAttr.product, id_value="Pixhawk4", platform=Platform.Pixhawk4),
SerialBoardIdentifier(attribute=SerialAttr.product, id_value="FMU v5.x", platform=Platform.Pixhawk4),
SerialBoardIdentifier(attribute=SerialAttr.product, id_value="CUAVv5", platform=Platform.Pixhawk4),
Copy link
Copy Markdown

@cursor cursor Bot Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUAVv5 mapped to wrong firmware platform

High Severity

The CUAVv5 board is mapped to Platform.Pixhawk4, but CUAVv5 has its own distinct firmware in the ArduPilot manifest (platform name "CUAVv5"). Since platform.value is used directly to query the manifest for firmware downloads, this mapping causes the system to download and install Pixhawk4 firmware onto CUAVv5 hardware. These boards have different sensor configurations, pin mappings, and peripheral assignments, so running the wrong firmware on a flight controller is a safety concern. A dedicated Platform enum entry for CUAVv5 is needed.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 99d08bc. Configure here.

SerialBoardIdentifier(attribute=SerialAttr.product, id_value="Pixhawk6X", platform=Platform.Pixhawk6X),
SerialBoardIdentifier(attribute=SerialAttr.product, id_value="FMU v6X.x", platform=Platform.Pixhawk6X),
SerialBoardIdentifier(attribute=SerialAttr.product, id_value="FMU v6C.x", platform=Platform.Pixhawk6C),
SerialBoardIdentifier(attribute=SerialAttr.product, id_value="CubeOrange", platform=Platform.CubeOrange),
Expand Down
Loading