test: add docSupport test and add docSupport version check#212
Closed
hukaidong wants to merge 2 commits into
Closed
test: add docSupport test and add docSupport version check#212hukaidong wants to merge 2 commits into
hukaidong wants to merge 2 commits into
Conversation
Contributor
Author
|
there are quite a lot of feedback on nix and(with) ruby communities about documentation failures. Here I'm trying to make this guardian as the first step. It make sure ri is working on compile-time ruby core documentations. Once this is merged, I gonna push an other pr work for gem documents. There's still some other built-in documentations like Rake, CSV not accessible through derivation. They are out of current scope and plan to fix in next one |
bobvanderlinden
approved these changes
Apr 7, 2026
Owner
bobvanderlinden
left a comment
There was a problem hiding this comment.
Ah ok, so running the docSupport part of the build in parallel results in problems in <3.4. These tests make sense 👍
There is a do-install-doc issue related to ruby version < 3.4. This commit checks doc support for ruby version >= 3.4 and add guard perventing docSupport be used in parallel build with early versions. See: ruby/rubygems#7580
4014f8b to
c4b44b4
Compare
auto-merge was automatically disabled
April 11, 2026 18:41
Head branch was pushed to by a user without write access
c4b44b4 to
a5172df
Compare
rdoc tries to create XDG_DATA_DIR (defaulting to $HOME/.local/share) during the build, but $HOME is read-only in the Nix sandbox. This adds a writable $HOME during the preConfigure phase, and applies the same fix to the docSupport tests in flake.nix. See: #221 Co-Authored-By: Sander <hey@sandydoo.me>
a5172df to
17a2474
Compare
Contributor
Author
|
I borrowed #221 change here so macOS check could be passed. |
a1fb85c to
17a2474
Compare
bobvanderlinden
added a commit
that referenced
this pull request
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a do-install-doc issue related to ruby version < 3.4.
This commit checks doc support for ruby version >= 3.4 and add guard
perventing docSupport be used in parallel build with early versions.
See: ruby/rubygems#7580