Guard startForeground calls with try/catch and add isForeground flag - #11
Merged
Merged
Conversation
mobily
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Google Play Console flags our production releases with a "Restricted foreground service types" warning, pointing at
com.brentvatne.exoplayer.VideoPlaybackService.onStartCommand. Apps targeting Android 15+ cannot startmediaPlaybackforeground services fromBOOT_COMPLETEDreceivers, and Play's static analysis flags the unconditionalstartForeground()call as a potential crash pathSolution
onStartCommandchange is a copy of v7'sisForegroundflag + try/catch around the placeholder notificationregisterPlayer'sstartForeground()call - this call site only exists in the legacy service (v7 usessetMediaNotificationProviderinstead)cc: @sharnik @szymonkoper @mobily