Skip to content

Guard startForeground calls with try/catch and add isForeground flag #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ludevv merged 1 commit into from
Jun 10, 2026
Merged

Guard startForeground calls with try/catch and add isForeground flag #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions android/src/main/java/com/brentvatne/exoplayer/VideoPlaybackService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ class VideoPlaybackService : MediaSessionService() {
private var mediaSessionsList = mutableMapOf<ExoPlayer, MediaSession>()
private var binder = PlaybackServiceBinder(this)
private var sourceActivity: Class<Activity>? = null
private var isForeground = false

// Controls for Android 13+ - see buildNotification function
private val commandSeekForward = SessionCommand(COMMAND.SEEK_FORWARD.stringValue, Bundle.EMPTY)
Expand Down Expand Up @@ -65,7 +66,12 @@ class VideoPlaybackService : MediaSessionService() {
addSession(mediaSession)

val notificationId = player.hashCode()
startForeground(notificationId, buildNotification(mediaSession))
try {
startForeground(notificationId, buildNotification(mediaSession))
isForeground = true
} catch (e: Exception) {
DebugLog.e(TAG, "Failed to start foreground service: " + e.message)
}
}

fun unregisterPlayer(player: ExoPlayer) {
Expand Down Expand Up @@ -249,8 +255,13 @@ class VideoPlaybackService : MediaSessionService() {
}

override fun onStartCommand(intent: Intent?, flags: Int, startId: Int): Int {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
startForeground(PLACEHOLDER_NOTIFICATION_ID, createPlaceholderNotification())
try {
if (!isForeground && Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
startForeground(PLACEHOLDER_NOTIFICATION_ID, createPlaceholderNotification())
isForeground = true
}
} catch (e: Exception) {
DebugLog.e(TAG, "Failed to start foreground service: " + e.message)
}

intent?.let {
Expand Down
Loading