no topk for openai test#234
Merged
Merged
Conversation
Alex Z (CLowbrow)
requested review from
Erin McNulty (erin2722) and
Ken Jiang (knjiang)
Erin McNulty (erin2722)
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add regression coverage for Google GenAI requests that include generationConfig.topK and are routed to OpenAI models: payloads/cases/params.ts now has a focused googleOpenAIModelTopKParam case, new Rust transform tests assert Google-shaped requests targeting Chat Completions or Responses drop unsupported top_k while preserving maxOutputTokens, and the payload fixtures/snapshots were regenerated to lock in the expected transforms.
https://linear.app/braintrustdata/issue/BT-4737/topk-definition-crashes-with-openai-models-in-google-sdk