Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions crates/lingua/src/processing/transform.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1188,6 +1188,74 @@ mod tests {
assert!(output.get("top_p").is_none(), "Should not have top_p");
}

#[test]
#[cfg(all(feature = "openai", feature = "google"))]
fn test_google_top_k_openai_model_drops_top_k_for_chat_completions() {
let payload = json!({
"contents": [{
"role": "user",
"parts": [{"text": "Write a short sentence about API gateways."}]
}],
"generationConfig": {
"topK": 1,
"maxOutputTokens": 1024
}
});
let input = to_bytes(&payload);

let result =
transform_request(input, ProviderFormat::ChatCompletions, Some("gpt-5-nano")).unwrap();

let output: Value = crate::serde_json::from_slice(result.as_bytes()).unwrap();
assert_eq!(result.source_format(), Some(ProviderFormat::Google));
assert_eq!(
output.get("model").and_then(Value::as_str),
Some("gpt-5-nano")
);
assert!(
output.get("top_k").is_none(),
"OpenAI Chat Completions should not receive top_k"
);
assert_eq!(
output.get("max_completion_tokens").and_then(Value::as_i64),
Some(1024)
);
}

#[test]
#[cfg(all(feature = "openai", feature = "google"))]
fn test_google_top_k_openai_model_drops_top_k_for_responses() {
let payload = json!({
"contents": [{
"role": "user",
"parts": [{"text": "Write a short sentence about API gateways."}]
}],
"generationConfig": {
"topK": 1,
"maxOutputTokens": 1024
}
});
let input = to_bytes(&payload);

let result =
transform_request(input, ProviderFormat::Responses, Some("gpt-5-nano")).unwrap();

let output: Value = crate::serde_json::from_slice(result.as_bytes()).unwrap();
assert_eq!(result.source_format(), Some(ProviderFormat::Google));
assert_eq!(
output.get("model").and_then(Value::as_str),
Some("gpt-5-nano")
);
assert!(
output.get("top_k").is_none(),
"OpenAI Responses should not receive top_k"
);
assert_eq!(
output.get("max_output_tokens").and_then(Value::as_i64),
Some(1024)
);
}

#[test]
#[cfg(feature = "openai")]
fn test_non_reasoning_model_still_passthroughs() {
Expand Down
19 changes: 19 additions & 0 deletions payloads/cases/params.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1505,6 +1505,25 @@ export const paramsCases: TestCaseCollection = {
bedrock: null,
},

googleOpenAIModelTopKParam: {
"chat-completions": null,
responses: null,
anthropic: null,
google: {
contents: [
{
role: "user",
parts: [{ text: "Write a short sentence about API gateways." }],
},
],
generationConfig: {
topK: 1,
maxOutputTokens: 1024,
},
},
bedrock: null,
},

streamParam: {
"chat-completions": null,
responses: null,
Expand Down
133 changes: 133 additions & 0 deletions payloads/scripts/transforms/__snapshots__/transforms.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading