fix(BRE2-800): Fix bug where deregister fails to delete etc data#312
Merged
fix(BRE2-800): Fix bug where deregister fails to delete etc data#312
Conversation
drewmalin
commented
Mar 5, 2026
| if err == nil { | ||
| return nil | ||
| } | ||
| if !os.IsPermission(err) { |
Contributor
Author
There was a problem hiding this comment.
Looking at the implementation here, this requires that err is exactly the "ErrPermission" error in the os package (which it is not, as the above "DeleteFile" call performs the typical "WrapAndTrace".
From the doc on this function:
// This function predates [errors.Is]. It only supports errors returned by
// the os package. New code should use errors.Is(err, fs.ErrPermission).
Validated that deregister functions again.
patelspratik
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.