Skip to content

fix(BRE2-800): Fix bug where deregister fails to delete etc data #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drewmalin merged 2 commits into from
Mar 5, 2026
+3 −1
Merged

fix(BRE2-800): Fix bug where deregister fails to delete etc data #312

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0c34d2
fix(BRE2-800): Fix bug where deregister fails to delete etc data
drewmalin Mar 5, 2026
aff792e
alternative fix
drewmalin Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/cmd/register/device_registration_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ package register
import (
"bytes"
"encoding/json"
"errors"
"fmt"
"io/fs"
"os"
"os/exec"
"path/filepath"
Expand Down Expand Up @@ -92,7 +94,7 @@ func (s *FileRegistrationStore) Delete() error {
if err == nil {
return nil
}
if !os.IsPermission(err) {
Copy link
Contributor Author

@drewmalin drewmalin Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the implementation here, this requires that err is exactly the "ErrPermission" error in the os package (which it is not, as the above "DeleteFile" call performs the typical "WrapAndTrace".

From the doc on this function:

// This function predates [errors.Is]. It only supports errors returned by
// the os package. New code should use errors.Is(err, fs.ErrPermission).

Validated that deregister functions again.

Copy link
Contributor

@patelspratik patelspratik Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh

if !errors.Is(err, fs.ErrPermission) {
return breverrors.WrapAndTrace(err)
}
// Fall back to sudo for non-root users.
Expand Down
Loading