Assert single editable control on Board groupBy/swimlaneBy primary field collision (closes #272)

[brylie]

Summary

Addresses #272 by hardening test assertions in BoardCollectionView.svelte.test.ts for the titleEditableViaCell derivation when a Collection's primary field matches config.groupBy or config.swimlaneBy:

• PR Board: fix redundant title control when primary field matches groupBy #259 originally resolved Board/Calendar: primary field and groupBy can point at the same field, showing redundant controls #104 by making the card title fall back to a plain static label (<span>) when the primary field collides with groupBy or swimlaneBy, and added tests verifying that only the expected number of comboboxes (1 for groupBy, 2 for swimlaneBy) rendered on the card.
• During PR reflection on Calendar entry titles render primary field as editable cell, matching Board #268 (which mirrored this pattern for Calendar under Calendar entries never render the primary field as an editable cell, unlike Board #105), issue Add regression test for Board's titleEditableViaCell primary-field/groupBy collision fallback #272 was filed noting the gap in explicit getAllByDisplayValue assertions and direct references to titleEditableViaCell.
• Updated both the groupBy and swimlaneBy collision tests in BoardCollectionView.svelte.test.ts to explicitly assert expect(within(card).getAllByDisplayValue(...)).toHaveLength(1), matching the pattern in CalendarCollectionView.svelte.test.ts and confirming that no duplicate PropertyValueCell is rendered.
• Verified that artificially removing the collision check from titleEditableViaCell in BoardCollectionView.svelte immediately causes both regression tests to fail.

Closes #272

Test plan

• Unit/component tests pass: npx vitest run src/lib/components/BoardCollectionView.svelte.test.ts (23 tests pass)
• Full test suite passes: npm run test (1296 tests pass across 85 test files)
• Linter passes: npm run lint
• Type check passes: npm run check
• Pre-push hook passed locally (format, lint, unit tests, coverage, build, Tier A & Tier B E2E tests)

Summary by CodeRabbit

• Bug Fixes
  • Improved board behavior when the primary field is used for grouping or swimlanes.
  • Ensured grouping and swimlane controls remain editable while other controls are not.
  • Prevented duplicate display of the primary value.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Essentials

Run ID: 3c5602ca-ba6e-4a60-be1f-71aa8fec66f2

📥 Commits

Reviewing files that changed from the base of the PR and between 8d3a6f5 and b59ded2.

📒 Files selected for processing (1)

• src/lib/components/BoardCollectionView.svelte.test.ts

Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.

---

📝 Walkthrough

Walkthrough

Board component tests now cover primary-field collisions with grouping and swimlane controls. The tests verify that the displayed primary value occurs once and that the title control remains the only editable control.

Changes

Board collision regression coverage

Layer / File(s)	Summary
Primary-field collision regression coverage src/lib/components/BoardCollectionView.svelte.test.ts	The grouping and swimlane tests identify titleEditableViaCell and verify one displayed value for the primary field.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to b59de

The change adds targeted coverage without modifying production behavior, and no merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the regression assertions for the single editable control when the Board primary field collides with groupBy or swimlaneBy. It accurately reflects the main change.
Linked Issues check	✅ Passed	The Board test file contains two regression tests for issue #104/#272. One sets primaryFieldKey equal to groupBy; the other sets it equal to swimlaneBy. Each test checks the static title label a…
Out of Scope Changes check	✅ Passed	The reviewed change is limited to src/lib/components/BoardCollectionView.svelte.test.ts. It adds or strengthens regression assertions for the linked collision behavior. It does not add unrelated pro…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test-272-board-title-collision-regression

---

_{Comment @coderabbitai help to get the list of available commands.}

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can hide the parts of a finding you never read, like the evidence or the agent prompt

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[qodo-code-review]

PR Summary by Qodo

Assert one Board control for primary-field grouping collisions

🧪 Tests 🕐 Less than 5 minutes

AI Description

• Strengthens Board collision regressions with value-specific editable-control cardinality
 assertions.
• Covers primary-field collisions with both groupBy and swimlaneBy configurations.
• Aligns Board coverage with the established Calendar test pattern.

Diagram

graph TD
  A["Collision fixture"] --> B["Render board"] --> C{"Primary collision"}
  C -->|groupBy| D["Column control"] --> F["Cardinality assertion"]
  C -->|swimlaneBy| E["Swimlane control"] --> F

Loading

High-Level Assessment

The targeted DOM cardinality assertions are the appropriate approach because they directly detect the duplicate PropertyValueCell regression while preserving the existing role-count checks. Snapshot testing or testing titleEditableViaCell indirectly would provide weaker behavioral guarantees.

Files changed (1) +6 / -4

Tests (1) +6 / -4

BoardCollectionView.svelte.test.tsAssert unique editable values for Board grouping collisions +6/-4

Assert unique editable values for Board grouping collisions

• Extends the groupBy and swimlaneBy primary-field collision tests with value-specific cardinality assertions for “To do” and “High.” The tests now explicitly prove that no redundant PropertyValueCell renders alongside the movement selectors and reference issue #272.

src/lib/components/BoardCollectionView.svelte.test.ts