Skip to content

Assert single editable control on Board groupBy/swimlaneBy primary field collision (closes #272) #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brylie merged 1 commit into from
Sep 12, 2026
Merged

Assert single editable control on Board groupBy/swimlaneBy primary field collision (closes #272) #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/lib/components/BoardCollectionView.svelte.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ describe('BoardCollectionView', () => {
expect(await screen.findByDisplayValue('Still primary')).toBeInTheDocument();
});

it('falls back to a plain, non-editable title label when the primary field is also the grouping property (issue #104)', async () => {
it('falls back to a plain, non-editable title label when the primary field is also the grouping property (issue #104/#272)', async () => {
createCollection(ydoc, {
id: 'col-1',
title: 'Board',
Expand Down Expand Up @@ -366,11 +366,12 @@ describe('BoardCollectionView', () => {
// plain text rather than its own editable control...
expect(within(card).getByText('To do', { selector: 'span' })).toBeInTheDocument();
// ...so the "Move to column" select is the only editable control for
// this value anywhere on the card.
// this value anywhere on the card (titleEditableViaCell, issue #104/#272).
expect(within(card).getAllByRole('combobox')).toHaveLength(1);
expect(within(card).getAllByDisplayValue('To do')).toHaveLength(1);
});

it('falls back to a plain, non-editable title label when the primary field is also the swimlane property (issue #104)', async () => {
it('falls back to a plain, non-editable title label when the primary field is also the swimlane property (issue #104/#272)', async () => {
createCollection(ydoc, {
id: 'col-1',
title: 'Board',
Expand Down Expand Up @@ -411,8 +412,9 @@ describe('BoardCollectionView', () => {
expect(within(card).getByText('High', { selector: 'span' })).toBeInTheDocument();
// ...so the "Move to column"/"Move to swimlane" selects are the only
// editable controls for their respective values — no third, redundant
// editable control for the primary field itself.
// editable control for the primary field itself (titleEditableViaCell, issue #104/#272).
expect(within(card).getAllByRole('combobox')).toHaveLength(2);
expect(within(card).getAllByDisplayValue('High')).toHaveLength(1);
});

it('adds a new option to a non-grouping select field from a card without touching the grouping property', async () => {
Expand Down
Loading