fix(dashboard): show pending invites as a badge in the members table - #444
Conversation
The invited marker sat as parenthesised text next to the role while the email column stayed empty for those rows, leaving a hole in the table and a crowded role cell. Move the marker into the empty middle column and render it with frappe-ui's Badge. Closes #435 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016kQ1Dp7xRj9mVNuYGeVYB2
Amber matches the pending state already used for scheduled communications.
Greptile SummaryThis PR moves the pending-invitation indicator from the role column into the otherwise-empty email column and renders it as a frappe-ui Badge.
Confidence Score: 4/5The change appears safe to merge, with a non-blocking visual mismatch between the implemented invitation badge and the treatment described by the PR. Member and invitation row behavior remains intact, but pending invitations render with an outline Badge rather than the intended subtle style. Files Needing Attention: dashboard/src/components/dashboard/teams/TeamMembersTable.vue
|
| Filename | Overview |
|---|---|
| dashboard/src/components/dashboard/teams/TeamMembersTable.vue | Repositions the invitation status into a Badge in the email column, but uses an outline treatment instead of the described subtle badge. |
Prompt To Fix All With AI
### Issue 1
dashboard/src/components/dashboard/teams/TeamMembersTable.vue:177
**Invitation badge style mismatch**
The PR specifies a gray, subtle invitation badge, but this uses the outline variant and omits the explicit gray theme. Pending-invite rows therefore render with a bordered treatment instead of the intended subtle badge.
```suggestion
<Badge v-else size="sm" theme="gray" variant="subtle" :label="__('Invited')" />
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "Merge branch 'develop' into fix/435-invi..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| carries its pending state instead. --> | ||
| <span class="flex min-w-0 items-center"> | ||
| <span v-if="row.member" class="truncate text-base text-ink-gray-6">{{ row.email }}</span> | ||
| <Badge v-else size="sm" variant="outline" :label="__('Invited')" /> |
There was a problem hiding this comment.
The PR specifies a gray, subtle invitation badge, but this uses the outline variant and omits the explicit gray theme. Pending-invite rows therefore render with a bordered treatment instead of the intended subtle badge.
| <Badge v-else size="sm" variant="outline" :label="__('Invited')" /> | |
| <Badge v-else size="sm" theme="gray" variant="subtle" :label="__('Invited')" /> |
Prompt To Fix With AI
This is a comment left during a code review.
Path: dashboard/src/components/dashboard/teams/TeamMembersTable.vue
Line: 177
Comment:
**Invitation badge style mismatch**
The PR specifies a gray, subtle invitation badge, but this uses the outline variant and omits the explicit gray theme. Pending-invite rows therefore render with a bordered treatment instead of the intended subtle badge.
```suggestion
<Badge v-else size="sm" theme="gray" variant="subtle" :label="__('Invited')" />
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
2 participants
(Invited)crammed next to the role, with an empty email cell beside it.theme="amber" variant="subtle") now fills that empty middle column; role cell shows just the role.yarn lint,yarn typecheck,yarn fmt:checkpass; no e2e spec references "Invited".