Skip to content

fix(dashboard): show pending invites as a badge in the members table #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harshtandiya merged 3 commits into from
Sep 8, 2026
+8 −7
Merged

fix(dashboard): show pending invites as a badge in the members table #444

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1713bf9
fix(teams): show pending invites as an Invited badge
claude Sep 7, 2026
be3ba67
fix(teams): use amber for the Invited badge
harshtandiya Sep 8, 2026
3116290
Merge branch 'develop' into fix/435-invited-badge
harshtandiya Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions dashboard/src/components/dashboard/teams/TeamMembersTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script setup lang="ts">
import { Avatar, Button, Dropdown, dialog, toast } from "frappe-ui"
import { Avatar, Badge, Button, Dropdown, dialog, toast } from "frappe-ui"
import { computed, ref } from "vue"

import ChangeRoleDialog from "@/components/dashboard/teams/ChangeRoleDialog.vue"
Expand Down Expand Up @@ -170,14 +170,15 @@ function confirmRetract(row: Row) {
<span class="truncate text-base text-ink-gray-8">{{ row.name }}</span>
</div>

<!-- An invite has only an address, already shown as its name. -->
<span class="truncate text-base text-ink-gray-6">{{ row.member ? row.email : "" }}</span>

<span class="truncate text-base font-medium text-ink-gray-8">
{{ row.role }}
<span v-if="!row.member" class="font-normal text-ink-gray-5">({{ __("Invited") }})</span>
<!-- An invite has only an address, already shown as its name, so the cell
carries its pending state instead. -->
<span class="flex min-w-0 items-center">
<span v-if="row.member" class="truncate text-base text-ink-gray-6">{{ row.email }}</span>
<Badge v-else size="sm" variant="outline" :label="__('Invited')" />

@greptile-apps greptile-apps Bot Sep 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Invitation badge style mismatch

The PR specifies a gray, subtle invitation badge, but this uses the outline variant and omits the explicit gray theme. Pending-invite rows therefore render with a bordered treatment instead of the intended subtle badge.

Suggested change
<Badge v-else size="sm" variant="outline" :label="__('Invited')" />
<Badge v-else size="sm" theme="gray" variant="subtle" :label="__('Invited')" />
Prompt To Fix With AI 
This is a comment left during a code review.
Path: dashboard/src/components/dashboard/teams/TeamMembersTable.vue
Line: 177

Comment:
**Invitation badge style mismatch**

The PR specifies a gray, subtle invitation badge, but this uses the outline variant and omits the explicit gray theme. Pending-invite rows therefore render with a bordered treatment instead of the intended subtle badge.

```suggestion
					<Badge v-else size="sm" theme="gray" variant="subtle" :label="__('Invited')" />
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code Fix in Codex

</span>

<span class="truncate text-base font-medium text-ink-gray-8">{{ row.role }}</span>

<Dropdown v-if="actionsFor(row).length" :options="actionsFor(row)" align="end">
<!-- label is the accessible name here: an icon slot makes it icon-only. -->
<Button
Expand Down
Loading