Skip to content

snapcraft: root: workflows: cargo publishing enablement#158

Merged
artiepoole merged 6 commits intomainfrom
artie/cargo_publish
Apr 14, 2026
Merged

snapcraft: root: workflows: cargo publishing enablement#158
artiepoole merged 6 commits intomainfrom
artie/cargo_publish

Conversation

@artiepoole
Copy link
Copy Markdown
Collaborator

@artiepoole artiepoole commented Mar 10, 2026 •
edited
Loading

This required the following changes:

  • added a version bump linter - cargo version must be changed when any source code/functional changes are present
  • the version is workspace wide, so that the fpgad_macros version is automatically changed when fpgad version is changed
  • the crate names have been changed (but directory structure remains) so we have fpgad, fpgad_macros and fpgad_cli
  • PUBLISHING.MD checklist document added to project root
  • created a "well-known-name" for the provider content by specifying the an ID - explicitly stating it like this:
plugs:
  provider-content:
  ...
    content: provider-content

@artiepoole artiepoole force-pushed the artie/cargo_publish branch 2 times, most recently from e5a03cc to d37c8c2 Compare March 10, 2026 16:31
@artiepoole artiepoole force-pushed the artie/cargo_publish branch 2 times, most recently from 7eee048 to c9db3af Compare March 24, 2026 09:57
@artiepoole artiepoole force-pushed the artie/document-daemon-remaining branch from b9873c6 to 6b4f386 Compare March 24, 2026 09:57
@artiepoole artiepoole force-pushed the artie/cargo_publish branch from c9db3af to 57b7208 Compare March 24, 2026 10:08
@artiepoole artiepoole force-pushed the artie/document-daemon-remaining branch 2 times, most recently from 66a5bd1 to e1aba62 Compare March 24, 2026 11:38
@artiepoole artiepoole force-pushed the artie/cargo_publish branch 2 times, most recently from b2b64a8 to ffce870 Compare March 24, 2026 16:19
@artiepoole artiepoole force-pushed the artie/document-daemon-remaining branch from e1aba62 to 992ea42 Compare March 24, 2026 16:19
@artiepoole artiepoole force-pushed the artie/cargo_publish branch from ffce870 to b8c948e Compare March 26, 2026 14:20
@artiepoole artiepoole force-pushed the artie/document-daemon-remaining branch 3 times, most recently from 427db72 to 8b60723 Compare March 26, 2026 14:40
@artiepoole artiepoole force-pushed the artie/cargo_publish branch 2 times, most recently from b3d3a4a to 84a195e Compare March 26, 2026 14:53
@artiepoole artiepoole force-pushed the artie/document-daemon-remaining branch from 757e673 to 25e8196 Compare March 26, 2026 15:21
@artiepoole artiepoole force-pushed the artie/cargo_publish branch from 84a195e to cfcf723 Compare March 26, 2026 15:21
@artiepoole artiepoole mentioned this pull request Mar 26, 2026
Merged
@artiepoole artiepoole changed the title Artie/cargo publish Changes required in order to publish fpgad to cargo Mar 26, 2026
@artiepoole artiepoole changed the title Changes required in order to publish fpgad to cargo Changes required in order to publish fpgad crates to cargo Mar 26, 2026
@artiepoole artiepoole force-pushed the artie/cargo_publish branch from cfcf723 to 98ec13a Compare March 26, 2026 15:28
@artiepoole artiepoole changed the title Changes required in order to publish fpgad crates to cargo cargo publishing enablement Mar 26, 2026
@artiepoole artiepoole changed the title cargo publishing enablement root: docs: cargo publishing enablement Mar 26, 2026
@artiepoole artiepoole added documentation Improvements or additions to documentation root workflows labels Mar 26, 2026
@artiepoole artiepoole force-pushed the artie/cargo_publish branch from cddada2 to e5de31e Compare April 1, 2026 07:47
@artiepoole artiepoole changed the title root: workflows: cargo publishing enablement snapcraft: root: workflows: cargo publishing enablement Apr 1, 2026
artiepoole
artiepoole commented Apr 1, 2026
View reviewed changes
@artiepoole artiepoole force-pushed the artie/cargo_publish branch from fce9a7e to f254ed8 Compare April 1, 2026 08:16
@artiepoole artiepoole requested a review from Copilot April 1, 2026 08:16
Copilot AI reviewed Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@artiepoole artiepoole force-pushed the artie/cargo_publish branch 3 times, most recently from fbb2a31 to ed89cdc Compare April 1, 2026 08:47
@artiepoole
Copy link
Copy Markdown
Collaborator Author

artiepoole commented Apr 1, 2026

example printouts

image image image

@artiepoole artiepoole force-pushed the artie/cargo_publish branch from ed89cdc to 70df418 Compare April 1, 2026 08:50
@artiepoole artiepoole marked this pull request as ready for review April 1, 2026 08:50
talhaHavadar
talhaHavadar requested changes Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@talhaHavadar talhaHavadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor request

@artiepoole
workflows: add linter to enforce version bump on change to source files
1cb48e8 
Signed-off-by: Artie Poole <stuart.poole@canonical.com>
@artiepoole
root: fix cargo dependency such that fpgad_macros is found from cargo…
15963f5 
… unless locally present

Signed-off-by: Artie Poole <stuart.poole@canonical.com>
@artiepoole
root: snapcraft.yaml - specify content identifier handle
ca57127 
Just explicitly specify the "content:" ID of the content interface

Signed-off-by: Artie Poole <stuart.poole@canonical.com>
@artiepoole artiepoole force-pushed the artie/cargo_publish branch from 70df418 to ca57127 Compare April 10, 2026 10:14
@github-actions github-actions bot requested a review from talhaHavadar April 10, 2026 10:14
talhaHavadar
talhaHavadar previously approved these changes Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@talhaHavadar talhaHavadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Artie!

@artiepoole artiepoole enabled auto-merge (squash) April 10, 2026 10:15
@github-actions github-actions bot requested a review from talhaHavadar April 10, 2026 13:36
@artiepoole
tests: fix coverage_test.sh after rename of daemon to fpgad
eb9960b 
Signed-off-by: Artie Poole <stuart.poole@canonical.com>
@artiepoole artiepoole force-pushed the artie/cargo_publish branch 2 times, most recently from 02b46e2 to eb9960b Compare April 14, 2026 08:09
@artiepoole
Copy link
Copy Markdown
Collaborator Author

artiepoole commented Apr 14, 2026 •
edited
Loading

I ran the binary integration tests (coverage_tests.sh) on my local kria due to infra issues. The results are green:
coverage.lcov
daemon.log
summary.txt

talhaHavadar
talhaHavadar approved these changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@talhaHavadar talhaHavadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you Artie!

@artiepoole artiepoole disabled auto-merge April 14, 2026 09:40
@artiepoole artiepoole merged commit 6ad0bf3 into main Apr 14, 2026
19 of 29 checks passed
@artiepoole artiepoole deleted the artie/cargo_publish branch April 14, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@talhaHavadar talhaHavadar talhaHavadar approved these changes

Assignees

No one assigned

Labels

cli documentation Improvements or additions to documentation root workflows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@artiepoole @talhaHavadar