-
Notifications
You must be signed in to change notification settings - Fork 0
snapcraft: root: workflows: cargo publishing enablement #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8f4254d
root: prepare for package publishing
artiepoole ccfb90f
snapcraft: rename binaries to match cargo crate names for publishing
artiepoole 1cb48e8
workflows: add linter to enforce version bump on change to source files
artiepoole 15963f5
root: fix cargo dependency such that fpgad_macros is found from cargo…
artiepoole ca57127
root: snapcraft.yaml - specify content identifier handle
artiepoole eb9960b
tests: fix coverage_test.sh after rename of daemon to fpgad
artiepoole File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,3 +37,6 @@ config: | |
| tests: | ||
| owners: | ||
| - artiepoole | ||
| snapcraft: | ||
| owners: | ||
| - artiepoole | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,15 @@ | ||
| [workspace] | ||
| resolver = "3" | ||
| members = ["daemon", "cli", "fpgad_macros"] | ||
|
|
||
| [workspace.package] | ||
| version = "0.1.0" | ||
| edition = "2024" | ||
| license = "GPL-3.0" | ||
| homepage = "https://github.com/canonical/fpgad" | ||
| repository = "https://github.com/canonical/fpgad" | ||
| authors = ["Talha Can Havadar <talha.can.havadar@canonical.com>", "Artie Poole <stuart.poole@canonical.com>"] | ||
|
|
||
| [workspace.dependencies] | ||
| fpgad_macros = { path = "fpgad_macros" } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| # Publishing Guide for FPGAd | ||
|
|
||
| This document explains how to publish the FPGAd packages to crates.io. | ||
|
|
||
| ## Package Structure | ||
|
|
||
| The workspace contains 3 packages: | ||
|
|
||
| 1. **`fpgad_macros`** - Procedural macros (must be published first) | ||
| 2. **`fpgad`** - The daemon (depends on fpgad_macros) | ||
| 3. **`fpgad_cli`** - Command-line interface | ||
|
|
||
| ## Publication Order | ||
|
|
||
| Packages must be published in this order due to dependencies: | ||
|
|
||
| 1. `fpgad_macros` (no dependencies on other workspace crates) | ||
| 2. `fpgad` (depends on fpgad_macros) | ||
| 3. `fpgad_cli` (no dependencies on other workspace crates, but logically depends on daemon) | ||
|
|
||
| ## Pre-publication Checklist | ||
|
|
||
| - [ ] All packages have proper metadata (version, license, description, etc.) | ||
| - [ ] All packages have README.md files | ||
| - [ ] Workspace-level metadata is shared across packages | ||
| - [ ] Dependencies have version requirements specified | ||
| - [ ] All packages compile successfully | ||
| - [ ] All tests pass (CI auto runs on PR) | ||
| - [ ] Documentation is complete | ||
| - [ ] CHANGELOG is up to date | ||
| - [ ] Git repository is clean | ||
|
|
||
| ## Publishing Commands | ||
|
|
||
| ### 1. Publish fpgad_macros | ||
|
|
||
| ```bash | ||
| cd fpgad_macros | ||
| cargo publish | ||
| ``` | ||
|
|
||
| ### 2. Publish fpgad | ||
|
|
||
| ```bash | ||
| cd daemon | ||
| cargo publish | ||
| ``` | ||
|
|
||
| ### 3. Publish fpgad_cli | ||
|
|
||
| ```bash | ||
| cd cli | ||
| cargo publish | ||
| ``` | ||
|
|
||
| ## Dry Run Testing | ||
|
|
||
| Before publishing, test with dry-run: | ||
|
|
||
| ```bash | ||
| cargo publish --dry-run | ||
| ``` | ||
|
|
||
| ## Version Updates | ||
|
|
||
| When releasing new versions, update the version in the workspace `Cargo.toml`: | ||
|
|
||
| ```toml | ||
| [workspace.package] | ||
| version = "X.Y.Z" # Update this | ||
| ``` | ||
|
|
||
| All packages will inherit this version. | ||
|
|
||
| Note that the CI pipeline will enforce an increase in the version whenever contents of a .rs file inside <part>/src is changed, before the commits can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.