Skip to content

fix: harden 'make help' for shell portability#542

Open
lengau wants to merge 5 commits into
mainfrom
work/fix-make-help
Open

fix: harden 'make help' for shell portability#542
lengau wants to merge 5 commits into
mainfrom
work/fix-make-help

Conversation

@lengau
Copy link
Copy Markdown
Collaborator

@lengau lengau commented Jun 3, 2026

I believe this fixes #538


  • I've followed the contribution guidelines.
  • I've signed the CLA.
  • I've successfully run make lint && make test.
  • I've added or updated any relevant documentation.
  • In documents I changed, I added a meta description if one was missing.
  • I've updated the relevant release notes.

Copilot AI review requested due to automatic review settings June 3, 2026 10:26
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the shared help make target implementation to be more portable under /bin/sh (and to avoid the quoting/EOF failure reported in #538) when generating the target help listing.

Changes:

  • Refactors the help recipe into a single-line awk program to avoid multi-line quoting issues under /bin/sh.
  • Suppresses command echoing for the separator line and makes the makefile list ordering more robust by falling back when tac is unavailable.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread common.mk Outdated
Comment thread common.mk Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread common.mk Outdated
Comment thread common.mk Outdated
Copilot finished work on behalf of lengau June 3, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: make help does not work

3 participants