Skip to content

fix: harden 'make help' for shell portability #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lengau wants to merge 5 commits into
base: main
Choose a base branch
from
+6 −18
Open

fix: harden 'make help' for shell portability #542

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
61f8592
build: suppress filenames in 'make help' output
lengau Jun 3, 2026
a097afc
build: harden 'make help' for shell portability and fix #538
lengau Jun 3, 2026
8e40470
fix: use POSIX-octal ESC (\033) instead of \e in printf
Copilot Jun 3, 2026
fac815e
fix: use grep -E and fix regex to support single-character targets
Copilot Jun 3, 2026
123940a
fix: address remaining common.mk portability review feedback
Copilot Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 6 additions & 18 deletions common.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,24 +36,12 @@ export UV_FROZEN := true

.PHONY: help
help: ## Show this help.
@printf "\e[1m%-30s\e[0m | \e[1m%s\e[0m\n" "Target" "Description"
printf "\e[2m%-30s + %-41s\e[0m\n" "------------------------------" "------------------------------------------------"
egrep '^[^:]+\: [^#]*##' $$(echo $(MAKEFILE_LIST) | tac --separator=' ') | sed -e 's/:[^#]*/ /' | sort -V | awk -F '[: ]*' \
'{
if ($$2 == "##")
{
$$1=sprintf(" %-28s", $$1);
$$2=" | ";
print $$0;
}
else
{
$$1=sprintf(" └ %-25s", $$1);
$$2=" | ";
$$3=sprintf(" └ %s", $$3);
print $$0;
}
}' | uniq
@printf "\033[1m%-30s\033[0m | \033[1m%s\033[0m\n" "Target" "Description"
@printf "\033[2m%-30s + %-41s\033[0m\n" "------------------------------" "------------------------------------------------"
@cat $$(echo $(MAKEFILE_LIST) | tac --separator=' ' 2>/dev/null || echo $(MAKEFILE_LIST)) | grep -E '^[^[:space:]][^:]*\:[^#]*##' | \
sed -e 's/:[^#]*/ /' | sort -V | \
awk -F '[: ]+' '{ if ($$2 == "##") { $$1=sprintf(" %-28s", $$1); $$2=" | "; print $$0; } else { $$1=sprintf(" └ %-25s", $$1); $$2=" | "; $$3=sprintf(" └ %s", $$3); print $$0; } }' | \
uniq

.PHONY: setup
setup: install-uv _setup-docs _setup-lint _setup-tests setup-precommit install-build-deps ## Set up a development environment
Expand Down