Conversation
Baltoli
force-pushed
the
bruce/eip-7997
branch
from
August 20, 2026 13:25
1d68532 to
45c5e72
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Baltoli
force-pushed
the
bruce/eip-7997
branch
from
August 20, 2026 14:02
45c5e72 to
68957ae
Compare
Baltoli
force-pushed
the
bruce/eip-7997
branch
from
August 26, 2026 08:37
68957ae to
6dec7f1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds initial plumbing for EIP-7997 by introducing a new trait feature flag and deploying the deterministic factory system contract during block header execution.
Changes:
- Extend
Traitswitheip_7997_active()and implement activation in bothEvmTraitsandMonadTraits. - Deploy the deterministic factory contract (EIP-7997) during
execute_block_header. - Wire the new implementation into the execution library build.
Verdict: NEEDS CHANGES
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| category/vm/evm/traits.hpp | Adds eip_7997_active() to the Traits concept and both trait families. |
| category/execution/ethereum/execute_block_header.cpp | Calls deterministic factory deployment as part of block-header execution. |
| category/execution/ethereum/deterministic_factory_contract.hpp | Declares the deployment helper for the EIP-7997 system contract. |
| category/execution/ethereum/deterministic_factory_contract.cpp | Implements deterministic factory deployment logic and instantiates across traits. |
| category/execution/CMakeLists.txt | Adds the new deterministic factory sources to the execution library. |
🤖 Generated with Claude Code
Suppressed comments (1)
category/execution/ethereum/deterministic_factory_contract.cpp:46
- Using
account_exists()here can skip deployment if the address was previously “created” by a balance transfer (balance-only account), leaving the system contract without code/nonce. The existing system-contract deploy path (deploy_block_hash_history_contract) usesaccount_has_code_or_nonce()for this reason.
if (MONAD_UNLIKELY(!state.account_exists(FACTORY_ADDRESS))) {
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Baltoli
force-pushed
the
bruce/eip-7997
branch
5 times, most recently
from
September 3, 2026 15:54
26fb909 to
958bc79
Compare
Contributor
Author
|
@claude Re-review; noting that spec tests have to come all at once in a separate stack |
Baltoli
force-pushed
the
bruce/eip-7997
branch
from
September 4, 2026 10:32
958bc79 to
416bbb8
Compare
Baltoli
force-pushed
the
bruce/eip-7997
branch
from
September 4, 2026 12:46
416bbb8 to
8a8aa68
Compare
Baltoli
force-pushed
the
bruce/eip-7997
branch
2 times, most recently
from
September 7, 2026 09:40
36e9542 to
d295a56
Compare
Baltoli
force-pushed
the
bruce/eip-7997
branch
from
September 9, 2026 10:18
feb36ca to
af2b4bc
Compare
Baltoli
requested review from
a team,
andreaslyn,
brett-monad,
cmcl,
dhil,
goodlyrottenapple,
khordadi,
m-alvarez,
mkolosick and
ryankeleti
September 9, 2026 10:53
ryankeleti
previously approved these changes
Sep 9, 2026
goodlyrottenapple
previously approved these changes
Sep 9, 2026
Baltoli
dismissed stale reviews from goodlyrottenapple and ryankeleti
via
September 9, 2026 15:23
5584a3c
Baltoli
force-pushed
the
bruce/eip-7997
branch
from
September 9, 2026 15:23
af2b4bc to
5584a3c
Compare
Baltoli
force-pushed
the
bruce/eip-7997
branch
from
September 10, 2026 10:51
5584a3c to
3479b3c
Compare
ryankeleti
force-pushed
the
bruce/eip-7997
branch
from
September 10, 2026 18:40
3479b3c to
2e55e5f
Compare
goodlyrottenapple
previously approved these changes
Sep 11, 2026
dhil
previously approved these changes
Sep 11, 2026
EIP-7997 specifies the deterministic deployment factory as a genesis predeploy for new chains, not an irregular state transition at fork activation. Monad testnet and mainnet already have the contract live at 0x4e59b44847b379578588920cA78FbF26c0B4956C, so only the devnet genesis alloc needs it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015A1Xg6kHnQHbRYc6gsk7Zv
Baltoli
dismissed stale reviews from dhil and goodlyrottenapple
via
September 14, 2026 12:24
9550c78
Baltoli
force-pushed
the
bruce/eip-7997
branch
from
September 14, 2026 12:24
2e55e5f to
9550c78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.