Conversation
Baltoli
force-pushed
the
bruce/enable-amsterdam-spec-tests
branch
from
September 4, 2026 14:29
39a1d28 to
c153a4d
Compare
This was referenced Sep 4, 2026
ryankeleti
previously approved these changes
Sep 4, 2026
Baltoli
force-pushed
the
bruce/enable-amsterdam-spec-tests
branch
from
September 7, 2026 09:24
c153a4d to
b8b7c06
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to test configuration and removes now-obsolete scaffolding, with only a minor comment typo noted.
Pull request overview
Enables the MONAD_NEXT Amsterdam spec suite to run normally by narrowing the exclusion list to the single known-incompatible fixture and removing the temporary WILL_FAIL scaffolding that existed only to keep ctest green when zero tests were selected.
Changes:
- Replace the blanket
BlockchainTests.*exclusion with a single excluded Amsterdam fixture. - Remove the
WILL_FAILguard in the Amsterdam spec job now that the suite is intended to execute.
Verdict: CORRECT
🤖 Generated with Claude Code
File summaries
| File | Description |
|---|---|
test/ethereum_test/exclude/MONAD_NEXT_amsterdam.cmake |
Narrows the exclusion list from a blanket skip to a single excluded fixture. |
test/ethereum_test/CMakeLists.txt |
Removes the WILL_FAIL workaround so the test job reports real failures/zero-test runs. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Baltoli
force-pushed
the
bruce/enable-amsterdam-spec-tests
branch
from
September 7, 2026 09:41
b8b7c06 to
d7c1248
Compare
Baltoli
changed the title
Baltoli
force-pushed
the
bruce/enable-amsterdam-spec-tests
branch
from
September 7, 2026 12:25
d7c1248 to
575f9a8
Compare
Baltoli
force-pushed
the
bruce/enable-amsterdam-spec-tests
branch
from
September 7, 2026 14:25
575f9a8 to
fcf9330
Compare
Baltoli
force-pushed
the
bruce/enable-amsterdam-spec-tests
branch
from
September 8, 2026 10:02
fcf9330 to
2a0e95f
Compare
Baltoli
force-pushed
the
bruce/enable-amsterdam-spec-tests
branch
from
September 9, 2026 10:23
2a0e95f to
28564b9
Compare
Baltoli
requested review from
brett-monad,
cmcl,
dhil,
goodlyrottenapple,
khordadi,
m-alvarez and
mkolosick
September 9, 2026 10:53
Baltoli
force-pushed
the
bruce/enable-amsterdam-spec-tests
branch
from
September 10, 2026 10:51
989f612 to
27e4d58
Compare
ryankeleti
previously approved these changes
Sep 10, 2026
brett-monad
force-pushed
the
bruce/enable-amsterdam-spec-tests
branch
from
September 10, 2026 13:59
27e4d58 to
cb81a64
Compare
ryankeleti
force-pushed
the
bruce/enable-amsterdam-spec-tests
branch
from
September 10, 2026 18:40
cb81a64 to
31bf8b1
Compare
ryankeleti
force-pushed
the
bruce/enable-amsterdam-spec-tests
branch
from
September 10, 2026 19:18
31bf8b1 to
5c68195
Compare
dhil
previously approved these changes
Sep 11, 2026
brett-monad
force-pushed
the
bruce/enable-amsterdam-spec-tests
branch
2 times, most recently
from
September 11, 2026 12:18
1279aac to
eef8e3e
Compare
dhil
previously approved these changes
Sep 11, 2026
brett-monad
force-pushed
the
bruce/enable-amsterdam-spec-tests
branch
2 times, most recently
from
September 11, 2026 18:51
24de545 to
ca1499e
Compare
dhil
previously approved these changes
Sep 11, 2026
Baltoli
dismissed
dhil’s stale review
September 14, 2026 12:29
The merge-base changed after approval.
Baltoli
force-pushed
the
bruce/enable-amsterdam-spec-tests
branch
from
September 14, 2026 12:31
ca1499e to
50a9fc0
Compare
brett-monad
force-pushed
the
bruce/enable-amsterdam-spec-tests
branch
from
September 15, 2026 16:34
50a9fc0 to
c040306
Compare
Drop the blanket BlockchainTests.* entry from exclude/MONAD_NEXT_amsterdam.cmake, leaving the exclusion list empty, and drop the WILL_FAIL scaffolding around the job and the comment explaining it. The guard existed to keep ctest green while the whole bundle was excluded, which the runner's "No tests were run" check turned into a non-zero exit. With every Amsterdam EIP in the pinned bundle now implemented on the commits below, the guard can never fire again and the job runs like every other spec suite. The feature commits underneath leave the exclusion file alone. The fixtures are generated with the whole fork active, so opening the suite (or filtering it) part-way up the stack either runs zero tests with the guard disarmed or fails on the EIPs not yet in the tree; enabling belongs in one place, here. Measured against tests-monad_eip7708+7843+7981+7997+8024+8246@v0.3.0 on this branch: 723 fixtures, 710 pass, 13 skip, 0 fail. The v0.3.0 bundle no longer contains type-3 (blob) transactions, so the eip7981 blob fixture that v0.2.0 needed excluded is gone. The skips are the for_monad_tentomonad_nextattime15k fork-transition fixtures, whose network has no revision_map.hpp entry; that harness gap predates this change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ttcfi1kTMXgxbhZ9hF52s3
brett-monad
force-pushed
the
bruce/enable-amsterdam-spec-tests
branch
from
September 15, 2026 20:27
c040306 to
ca34cc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inverse of #2535. That PR pinned the combined Amsterdam fixture bundle and switched the
MONAD_NEXTAmsterdam spec job off behind a blanketBlockchainTests.*exclusion, with aWILL_FAILguard so ctest stayed green while nothing ran. Now that every EIP in that bundle is implemented on this stack (#2439 → #2499 → #2512 → #2469 → #2407), the suite runs for real, so this drops the scaffolding.Change
exclude/MONAD_NEXT_amsterdam.cmake: replace the blanketBlockchainTests.*entry with the single EIP-4844 blob fixture Monad cannot run.CMakeLists.txt: remove theWILL_FAILguard and its comment, since the guard can never fire again.The feature PRs underneath leave the exclusion file alone. The fixtures are generated with the whole fork active, so opening or filtering the suite part-way up the stack either runs zero tests with the guard disarmed (which is what broke CI on #2512) or fails on the EIPs not yet in the tree (#2469). Enabling belongs in one place, here.
Measured
Against
tests-monad_eip7708+7843+7981+7997+8024+8246@v0.2.0on this branch, unfiltered:The single failure is the blob fixture already excluded, so the ctest job passes as configured. The skips are the
for_monad_tentomonad_nextattime15kfork-transition fixtures, whose network has norevision_map.hppentry — a harness gap that predates this stack.Sits on top of #2407.
🤖 Generated with Claude Code
https://claude.ai/code/session_019VKRBQPBtf5k1JbBH28hVe