EIP-8246 (remove SELFDESTRUCT burn)

[brett-monad]

Removes the two paths by which SELFDESTRUCT still destroys ETH. This is a prerequisite of EIP-7708 rather than an adjacent EIP — 7708's current text lists requires: 8246 and no longer specifies a burn — which is what lets the 7708 implementation land with no Burn log at all. That is a sequencing constraint rather than a code one: 8246 must be live before 7708 is, or 7708 would claim complete native-value logging while two burn paths went unlogged.

Rule 1: a same-transaction account destructing to itself keeps its balance. State::selfdestruct moves the balance whenever the beneficiary differs; for the destruct-to-self case one predicate, selfdestruct_to_self_burns, holds the revision rule: always before Cancun, only for a same-transaction account under EIP-6780, never under EIP-8246.

Rule 2: at finalization a destructed account holding a balance is preserved — nonce reset, code and storage cleared, balance untouched — rather than deleted. Nonce and code are cleared first and EIP-161 is applied to the result, so an empty account is still deleted. Rule 2 also covers the EIP's second burn, value sent to an account already marked for selfdestruction, because it keys on the balance rather than on who the beneficiary was.

Gated on a new eip_8246_active(), which is >= MONAD_ETH_AMSTERDAM in both trait families; pre-Amsterdam revisions must keep burning.

Reserve balance is deliberately unchanged

A preserved account is a funded, nonce-0, codeless address, and no predicate distinguishes it from an ordinary pre-funded address — three Account fields match by construction, and the fourth, incarnation, is drawn from the same source for both and is absent from the merkle account. So it takes the existing MIP-4 floor exactly as a pre-funded address does today. Exempting it would mean making the storage-generation key carry account provenance, and that equivalence is the reason not to.

Spec tests

No change to the Amsterdam exclusion list. The Amsterdam suite is disabled at
this commit and opens once every Amsterdam EIP is in the tree. Nothing needs
excluding: the pinned bundle is generated with 8246 in effect, and its nine
selfdestruct fixtures all pass against this tree. The unit tests are the gate
on this PR.

Testing

Full MONAD_COMPILER_TESTING=ON build clean. ctest clean apart from the known BacktraceTest.works. All spec-test jobs pass. clang-format and license.sh clean.

Known limitation: the exec-event schema cannot express a code-cleared surviving account.

🤖 Generated with Claude Code

https://claude.ai/code/session_01T2YcdwU1mj3Lqunp9Y7pqa

[github-actions]

Reviewed the EIP-8246 implementation covering State::selfdestruct, State::destruct_suicides, the trait flag, the state-diff tracer comment, and the coinbase-award comment in execute_transaction.cpp.

The selfdestruct reshuffle is correct: the new eip_8246_active arm collapses to a no-op when address == beneficiary (no burn) and to a transfer otherwise, and the pre-Cancun and Cancun-only arms are unchanged. The destruct_suicides refactor preserves prior semantics for < Cancun (unconditional reset), for post-Cancun with mismatched incarnation (skip), and for post-Cancun with matching incarnation under !eip_8246_active (reset). The new preservation path only fires when the account was created this tx, has non-zero balance, and mutates in place so that the incarnation drives the reincarnation flag through commit — I verified Account::operator== includes incarnation and that create_contract stamps it. The storage-zeroing iterates the original map, which is the correct superset given set_storage/get_storage both populate the original map before or in place of current. MONAD_ASSERT(orig != original_.end()) holds because the only path that inserts into current_ is current_account_state, which first goes through original_account_state. The destruct_touched_dead interaction is sound: a preserved account has balance > 0, so is_dead is false and the untemplated pass spares it. can_merge/relaxed-merge ordering (before execute_final) leaves the preservation unaffected. The tests are thorough — the preserved-storage, credit-after-destruct, touched-dead, merge-through-trie, state-root-parity, and same-block-recreation cases each pin a distinct invariant.

Verdict: CORRECT

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Implements EIP-8246, removing SELFDESTRUCT balance burns and preserving funded accounts from Amsterdam onward.

Changes:

• Adds Amsterdam-gated EIP-8246 support.
• Updates transfer and finalization behavior.
• Expands state, storage, merge, and tracing tests.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Summary
category/vm/evm/traits.hpp	Adds the EIP-8246 activation predicate.
category/execution/ethereum/trace/state_tracer.cpp	Documents preserved-account tracing behavior.
category/execution/ethereum/test/test_call_trace.cpp	Verifies SELFDESTRUCT trace values.
category/execution/ethereum/state3/state.cpp	Implements non-burning and account-preservation logic.
category/execution/ethereum/state2/test/test_state.cpp	Tests preservation, deletion, storage clearing, and commits.
category/execution/ethereum/execute_transaction.cpp	Documents finalization ordering.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.