Skip to content

fix: repair split bullets in four chief-* Never lists, close utilisation lint gap - #35

Merged
cbrock84 merged 1 commit into
cbrock84:mainfrom
VishnuVuggepalli:fix/never-block-splits-and-utilisation
Sep 3, 2026
Merged

fix: repair split bullets in four chief-* Never lists, close utilisation lint gap#35
cbrock84 merged 1 commit into
cbrock84:mainfrom
VishnuVuggepalli:fix/never-block-splits-and-utilisation

Conversation

@VishnuVuggepalli

Copy link
Copy Markdown

Two shipped defects found while reading all 172 skills. Both have mechanical fixes; scripts/check-all.sh passes.

1. Four chief-* skills have a corrupted ## Never list

In each, a "Do not …" list was merged into a "Never …" list and the splice landed inside a wrapped bullet, orphaning its continuation onto an unrelated rule.

file bullet ends mid-sentence continuation landed at
security/chief-information-security-officer :116 "…exist as documented," :120
corporate-strategy/chief-strategy-officer :88 "…serves a thesis written" :91
customer-experience/chief-customer-officer :76 "…Count the contacts" :79
data-analytics/chief-data-officer :93 "…you will find out" :97

The CISO file rendered as:

- Do not fix another team's finding for them and leave the cause in place
  which is a different question from whether they work.

Each split bullet is reunited, and the two voices are ordered consistently — Never-voiced items first, Do-not-voiced after. The CISO file also stated one rule twice (:117 and :121); the fuller wording is kept.

No wording is changed beyond rejoining sentences that were already there.

2. check-us-english.py missed utilisation

scripts/check-us-english.py:57 listed utilise/utilised/utilising but not the noun form — though every sibling entry carries its -ation form (organisation, prioritisation, optimisation, realisation, minimisation, maximisation).

Three British spellings were shipping in operations/capacity-and-demand-planning while CI reported clean. Red → green:

before:      US English: 0 British spelling(s)      ← 3 were shipping
with entry:  capacity-and-demand-planning:35  'Utilisation' -> 'Utilization'
             capacity-and-demand-planning:46  'utilisation' -> 'utilization'
             capacity-and-demand-planning:57  'utilisation' -> 'utilization'
             US English: 3 British spelling(s)   exit=1
after --fix: US English: 0 British spelling(s)   exit=0

The prose was corrected by the script's own --fix, so that wording is yours, not mine.

Verification

scripts/check-all.sh — all green: 172 skills valid, provenance clean, README / social card / org chart current, 273 skill references resolve, manifests parse.


Seven further findings from the same read — including a docs/USE-CASES.md reference that ships in no plugin, and a description/body mismatch in partnership-marketing — are in a companion issue. Those are authorial calls rather than mechanical fixes, so I left them out of this PR.

…ion lint gap

Four chief-* skills shipped a corrupted `## Never` section. In each, a "Do not …"
list was merged into a "Never …" list and the splice landed inside a wrapped
bullet, orphaning its continuation onto an unrelated rule:

  security/chief-information-security-officer  :116 -> :120
  corporate-strategy/chief-strategy-officer    :88  -> :91
  customer-experience/chief-customer-officer   :76  -> :79
  data-analytics/chief-data-officer            :93  -> :97

The CISO file rendered as "Do not fix another team's finding for them and leave
the cause in place / which is a different question from whether they work." It
also stated one rule twice (:117 and :121); the fuller wording is kept.

Each split bullet is reunited and the two voices are ordered consistently:
Never-voiced items first, Do-not-voiced items after.

Separately, check-us-english.py listed utilise/utilised/utilising but not the
noun form, though every sibling entry carries its -ation form (organisation,
prioritisation, optimisation, realisation, minimisation, maximisation). Three
British spellings shipped in operations/capacity-and-demand-planning while CI
reported "0 British spelling(s)". Adding the entry makes the check catch them;
the prose was corrected by the script's own --fix, so the wording is unchanged
from the author's.

scripts/check-all.sh passes: 172 skills valid, 273 skill references resolve.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants