feat: add filterPlaceholder support to DefaultColumnFilter#93
Open
Abhishek9639 wants to merge 1 commit intocertego:developfrom
Open
feat: add filterPlaceholder support to DefaultColumnFilter#93Abhishek9639 wants to merge 1 commit intocertego:developfrom
Abhishek9639 wants to merge 1 commit intocertego:developfrom
Conversation
Abhishek9639
force-pushed
the
feature/filter-placeholder-support
branch
from
1669284 to
5476c72
Compare
5 tasks
Author
|
Greetings @mlodic, |
Contributor
|
I don't have access to this repo anymore, I need @drosetti or @fgibertoni to merge this |
Author
|
Greetings @drosetti or @fgibertoni, Could you please review and merge this PR when you have a moment? @mlodic has already reviewed the approach and is waiting on this certego-ui PR to be merged first. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added support for an optional
filterPlaceholderprop in [DefaultColumnFilter] component.This allows consumers (like IntelOwl) to customize the placeholder text for specific columns (e.g., showing "Search ID" instead of the default "Search keyword..").
Changes
filterPlaceholderfrom the column definitionfilterPlaceholderis provided, it is used as the input placeholder"Search keyword.."(backward compatible)Related