Skip to content

feat: customize placeholder in ID columns to 'Search ID'#3504

Open
Abhishek9639 wants to merge 1 commit intointelowlproject:developfrom
Abhishek9639:feature/customize-id-placeholder
Open

feat: customize placeholder in ID columns to 'Search ID'#3504
Abhishek9639 wants to merge 1 commit intointelowlproject:developfrom
Abhishek9639:feature/customize-id-placeholder

Conversation

@Abhishek9639
Copy link
Copy Markdown
Contributor

@Abhishek9639 Abhishek9639 commented Mar 20, 2026

Closes #1553

Description

Customized the placeholder text in ID column filters from "Search keyword.." to "Search ID" for better user clarity.

Added filterPlaceholder: "Search ID" to the ID column definition in all 5 table files:

  • [analyzablesTableColumns.jsx]
  • [analyzablesHistoryTableColumns.jsx]
  • [investigationTableColumns.jsx]
  • [jobTableColumns.jsx]
  • [userEventsTableColumns.jsx]

Companion PR for certego-ui library change: certego/certego-ui#93

Type of change

  • New feature (non-breaking change which adds functionality).

Checklist

  • I have read and understood the rules about [how to Contribute] to this project
  • The pull request is for the branch develop
  • I have updated the certego-ui library if needed (companion PR link above)
  • The tests are passing locally

@Abhishek9639
Copy link
Copy Markdown
Contributor Author

Abhishek9639 commented Mar 20, 2026

Greetings @mlodic,
I’ve completed the implementation for #1553 (customizing the placeholder in ID column filters) and addressed it at both the library and IntelOwl levels.
Everything has been tested locally and all CI checks are passing.
Whenever you get a chance, could you please review this PR? I’d really appreciate your feedback and I’m happy to make any changes if needed.
Thanks

Done.by.2.pr.mp4

@mlodic
Copy link
Copy Markdown
Member

mlodic commented Mar 22, 2026

sorry but the quality of the video is very bad. Can you please share where did you find that filterPlaceholder attribute? thanks

@Abhishek9639
Copy link
Copy Markdown
Contributor Author

Greetings @mlodic,
sorry for the bad video quality

filterPlaceholder is not an existing attribute. I created it myself by extending the [DefaultColumnFilter] component in the certego-ui library to accept this new optional prop.

The companion PR showing this change is here:
certego/certego-ui#93

In that PR, now reads filterPlaceholder from the column definition and uses it as the input placeholder, falling back to "Search keyword.." if not provided.

Please let me know if this approach is correct.
Thanks

@mlodic mlodic added the keep-open To avoid workflow closing PRs label Mar 22, 2026
@mlodic
Copy link
Copy Markdown
Member

mlodic commented Mar 22, 2026

we'll keep open until the certego-ui PR is merged

@Abhishek9639
Copy link
Copy Markdown
Contributor Author

Abhishek9639 commented Mar 22, 2026

Greetings @mlodic,
May I start working on another issue? Please let me know.
Thanks

@mlodic
Copy link
Copy Markdown
Member

mlodic commented Mar 22, 2026

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

keep-open To avoid workflow closing PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants