chore: remove archive directory and stale release docs#11
Merged
Conversation
4 tasks
lxcong
added a commit
that referenced
this pull request
Apr 23, 2026
…#12) ## Summary Fixes two issues with the Claude reviewer observed on PR #11 (73-file archive removal): 1. **Max-turns exhausted**: `--max-turns 8` was enough for small PRs but ran out on a 73-file diff. Bumped to 20. 2. **Mandatory "Read each file" rule**: for large PRs this is token-wasteful and unnecessary. Changed to selective: Read-each for PRs ≤15 files; diff-only for PRs >15 files (with escape hatch to Read if a suspected Critical finding needs context). Also added an explicit skip list: `skills/agentkey/references/`, lock files, generated/vendored content — never Read those, they're noise. ## Expected behavior (this PR's own review) This PR is 1 file, 12/5 line change. Should trigger STEP 2's Read-each path. Should post `✅ No issues found` within ~3 turns. ## Test plan - [x] YAML valid - [x] Does NOT touch archive/** (rule still in effect — good) - [ ] Claude reviewer comments on this PR, passes within budget - [ ] Future large PRs (>15 files) get a "Large PR — diff-only review" comment ## Note Because this PR modifies `.github/workflows/claude-pr-review.yml`, Claude Code GitHub App's security mechanism will refuse to run the reviewer on it (workflow diff-from-main guard). Expect `review` check to fail with "Workflow validation failed" — that's the security feature working, not a real failure. Merging anyway; from next PR onward the tuned version takes effect. Co-authored-by: lxcong <lxhtheresa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
archive/entirely and syncs all doc references. Archive held historical code from the pre-public-release era:archive/cli/— old@agentkey/cliworkspace (retired; superseded bynpx skills add chainbase-labs/agentkey)archive/scripts/—inject.sh,install-openclaw.sh,setup-key.sh, and the oldrelease.sh(retired; superseded by release-please)archive/docs/— OPENCLAW_INSTALL, QA checklists, QA report from the pre-1.0 flowarchive/pnpm-workspace.yaml,archive/pnpm-lock.yaml,archive/README.md— retired pnpm workspace scaffoldNone of it is referenced from active code. History is preserved in git (visible via
git log --diff-filter=D --summaryorgit show <commit>:archive/path) for anyone who needs to look back.Incidental cleanup (same PR)
The directory tree snippets in
README.mdanddocs/README_zh.mdwere stale (they still listedscripts/release.shand calledversiona "release.sh-managed" file). Updated to reflect:release.shis gone (release-please took over)version→version.txt(renamed in fix: rename version to version.txt for release-please auto-bump #7)./scripts/release.sh patch/minor/majorinvocation.claude/CLAUDE.mdsimilarly updated: dropped thearchive/directory-tree line, thearchive/paragraph, and the "re-add OpenClaw" bullet..github/workflows/claude-pr-review.ymlhad a convention rulearchive/** — retired codewhich is vacuously true now; removed so the prompt stays accurate.Expected Claude reviewer behavior
The reviewer should flag this PR as⚠️ Convention violation on the grounds that
version.txt/CHANGELOG.md/ release-please-managed files shouldn't be touched directly — but none of those are modified in this PR. The reviewer should produce a clean ✅ or Suggestion-level output at worst.This PR is partially a live test of the reviewer:
ClaudeGitHub App install +ANTHROPIC_API_KEYsecret get set up? If yes, we'll see a🤖 Claude security reviewcomment.Test plan
git rm -r archive/— 69 files removedarchive/anymore (verified:grep -rn 'archive/' --exclude-dir=.gitis empty)python3 -c "import yaml; yaml.safe_load(...)")chore:so release-please should NOT open a release PR