Fix broken multiline commit messages and multiple commits - #27
Merged
Conversation
|
@LeonardChallis tested the patch. looks good! |
Contributor
Author
|
@glensc Great, thanks for testing! |
JoshMcCullough
added a commit
to JoshMcCullough/git-slack-hook
that referenced
this pull request
May 7, 2016
|
Yep, patch works, thanks. |
Replace newlines in the payload JSON with the \n escape sequence.
Contributor
|
+1 on merging this pull request. I've been using this version for my own Git repositories for a while and it works great! Thank you for the fix. |
This was referenced Aug 8, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes both multiple commits not showing up properly, and also allows for multiple lines in a commit messages (even if grouped with multiple commits).
Changed the format of the
git logso that two replacements could be made - this was instead of some hugesedscript or using other tools like Perl, to keep things simple.Tested with 1 commit single and multiline messages, and multiple commits with both single and multiline messages.
Fixes #20 and #24, simplifies the solution proposed by pull request #26 - indeed with this, #26 wouldn't be needed and as mentioned on the comments page for that pull request it doesn't work for multiline messages.
Would appreciate feedback!