feat: verify death certificate issuing authority and accepted forms#34
Conversation
|
Merged! This is your best PR yet @HirenGajjar. The level of source verification here is exactly what Clarvia needs:
This is the kind of rigorous, source-backed work that makes Clarvia's data trustworthy. Five merged PRs across both repos now - you're a core contributor. Also good catch on issue #30 (CI workflow already exists). I'll close that one. Next challenges if you're interested:
|
|
Hey @HirenGajjar - we've just sent you collaborator invitations to both workflow-data and workflow-web with write access. Check your GitHub notifications or email to accept. What this means for you:
Five merged PRs across both repos, source verification research, schema-aware contributions - you've earned this. Welcome aboard properly. If you have any questions about the workflow or want to discuss anything, feel free to open a discussion or comment on any issue. |
Closes #29
Researched two official Guichet.lu source pages to verify the two unknown fields.
Issuing authority
Source: Declaration of death page — https://guichet.public.lu/en/citoyens/life-event/famille-education/deces-proche.html
Source: Death certificate page — https://guichet.public.lu/en/citoyens/justice/certificats-copies-actes-casier-judicaire/certificats-copies-actes/acte-deces.html
Conclusion: The issuing authority is the civil registrar's office (Bureau de l'état civil) of the communal administration in the commune where the death occurred.
issuing_authority_idremainsnull— no matching institution record exists indata/institutions/lu/. A new institution record for Luxembourg communal administrations will need to be created.Accepted forms
Source: Death certificate page — https://guichet.public.lu/en/citoyens/justice/certificats-copies-actes-casier-judicaire/certificats-copies-actes/acte-deces.html
Conclusion: Families receive extracts (partial reproductions) and full copies, both issued officially by the civil registrar. Mapped to schema enum values:
certified_copy— extracts issued as standard at declaration, issued by an official government bodycopy— additional full copies available on requestSchema compliance
Before making any changes, I read
schemas/v0.1/document_requirement.schema.jsoncarefully.The
accepted_formsfield has a strict enum:["original", "copy", "certified_copy", "digital", "unknown"]extractandfull_copyare not valid values in this schema. The Guichet source uses the word "extract" to describe what families receive, but the correct schema mapping iscertified_copy(extracts issued by an official government body) andcopy(additional full copies on request). All values in this PR are valid enum entries confirmed against the schema before committing.Other changes
verification_status:discovered→structured-from-sourceprovenance.updated_atandupdated_bysetVerified
python3 scripts/validate.py— passes (8 data files)