feat: add Bureau de l'état civil institution, death certificate source, and link issuing authority#38
Merged
TommiLindfors merged 1 commit intoMay 26, 2026
Conversation
…e, and link issuing authority (closes clarvia-org#37)
Contributor
|
Merged! This is a milestone @HirenGajjar - your first multi-file PR, and it's flawless. A few things that stood out:
Seven merged PRs. You're now an outside collaborator with write access and you're operating at maintainer quality. The about page issue (workflow-web #29) is waiting if you want to switch back to the web repo. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37
Follows up on PR #34 where
issuing_authority_idwas leftnullpending creation of the institution record. This PR closes that loop with 3 files: 1 new source, 1 new institution, 1 updated document requirement.Files changed
1.
data/sources/lu/guichet-death-certificate.yaml— new fileA distinct source record for the dedicated Guichet death certificate page, separate from the general death life event page already in the repo.
id:source:lu:guichet:death-certificateurl: https://guichet.public.lu/en/citoyens/justice/certificats-copies-actes-casier-judicaire/certificats-copies-actes/acte-deces.htmllanguages: en, fr, de (page has all three versions)guichet-death-life-event.yaml2.
data/institutions/lu/bureau-etat-civil.yaml— new fileInstitution record for the civil registrar's office (Bureau de l'état civil) of the communal administration.
Source evidence:
Schema compliance: Read
schemas/v0.1/institution.schema.jsoncarefully before writing. The schema hasadditionalProperties: false— noname_frorname_defields are permitted.nameis a single string only.functionis a free-text string, not an enum.Design note: The Bureau de l'état civil exists within every communal administration in Luxembourg. This record represents the institution type, not any specific commune's office. This is documented in
notes.official_site: the Guichet death certificate page — the most authoritative reference available, as the institution has no single national websitelanguages:[fr, de, lb]— Luxembourg's three official languagesverification_status:structured-from-source3.
data/document_requirements/lu/death-certificate.yaml— updatedissuing_authority_id:null→institution:lu:bureau-etat-civilsource_ids: addedsource:lu:guichet:death-certificateprovenance.updated_at:2026-05-25notes: updated to reflect completed linkSource evidence
Page: https://guichet.public.lu/en/citoyens/justice/certificats-copies-actes-casier-judicaire/certificats-copies-actes/acte-deces.html
Section: "How to proceed / Submitting the application"
Verified
python3 scripts/validate.py— passes (10 data files, up from 8)git status— exactly 2 new files + 1 modified, nothing else touched