fix(bias): idle=circadian joins night_look out of window, instead of going dark - #13
Merged
Merged
Conversation
…going dark Confirmed live 2026-08-08: with night_look configured, the driven zone (Circadian Core) sat at a dim red ambient look all night while every idle=circadian bias light (the whole viewing set in the live config -- Play bars, couch, light tree, dining table, side table) went fully off out of the circadian window. Read as broken, not intentional -- the design intent (already stated in CLAUDE.md: "TV off -> ... matches the rest of the room") was that TV-on is the *only* thing that should set a light apart from the rest of the home; TV off should mean rejoin the theme, not switch to its own separate day/night schedule. The out-of-window half of that was never actually implemented -- only the in-window (follow the curve) half was. bias_actions() gains a night_look parameter: idle=circadian, out of window (or in-window with no curve sample), night_look configured -> BiasHold at that same look, same as the main zone's own parked state. Falls back to off when night_look isn't configured, unchanged. idle=off is untouched either way. Reuses BiasHold (already carries a full LightState, hex included) rather than extending BiasDrive, which is mirek-only. 3 pure tests + 1 daemon-level integration test, verified to fail on the pre-fix code (branch disabled, ran red, restored) and pass on the fix. Full suite (397 tests) + mypy clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-landing 251af28 through a proper PR (originally direct-pushed to main,
reverted in #9).
Confirmed live 2026-08-08: with night_look configured, the driven zone sat
at a dim red ambient look all night while every idle=circadian bias light
(the whole viewing set in the live config) went fully off out of the
circadian window. Read as broken, not intentional — the design intent
(already stated in CLAUDE.md: "TV off -> ... matches the rest of the room")
was that TV-on is the only thing that should set a light apart from the rest
of the home; TV off should mean rejoin the theme. The out-of-window half of
that was never actually implemented.
bias_actions()gains anight_lookparameter: idle=circadian, out ofwindow (or in-window with no curve sample), night_look configured -> holds
that same look. Falls back to off when night_look isn't configured.
3 pure tests + 1 daemon-level integration test, verified to fail on the
pre-fix code (branch disabled, ran red, restored).