Roe 2308 sdk remove roe save resume flag#583
Draft
mattch1 wants to merge 4 commits intofeature/roe-1941-remove-validation-sr-flagsfrom
Draft
Roe 2308 sdk remove roe save resume flag#583mattch1 wants to merge 4 commits intofeature/roe-1941-remove-validation-sr-flagsfrom
mattch1 wants to merge 4 commits intofeature/roe-1941-remove-validation-sr-flagsfrom
Conversation
Contributor
|
Commit message needs a reference to the JIRA ticket. Currently pointing at some GitHub changes... |
markpit
reviewed
Jul 24, 2023
| transactionId: string, | ||
| body: OverseasEntity, | ||
| isSaveAndResumeFeatureActive: boolean = false | ||
| body: OverseasEntity |
Contributor
There was a problem hiding this comment.
the isSaveAndResumeFeatureActive will still be needed for the update journey, this function is called by createOverseasEntity in overseas.entities.service which is used by update.filing.date.controller among other things.
Contributor
There was a problem hiding this comment.
actually, if that flag is needed then the endpoint will be, so if we are removing the old /start endpoint then the update s & r feature flags will have to be removed from the web as well as there will be no way to save the data all in one go. So looks like we may have to get confirmation from kainos that we can remove their feature flag too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/companieshouse/overseas-entities-web/pull/986/files
Removed save and resume flag and reference to /start endpoint.