Skip to content

Roe 2308 sdk remove roe save resume flag #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mattch1 wants to merge 4 commits into
base: feature/roe-1941-remove-validation-sr-flags
Choose a base branch
from
Draft

Roe 2308 sdk remove roe save resume flag #583

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a12d2e
ROE-2308 Removed Save and Resume flag from ROE
mattch1 Jul 17, 2023
c186728
ROE-2308 Remove dist
mattch1 Jul 17, 2023
cf4bf5f
Temp: add dist folder
mattch1 Jul 21, 2023
60905cf
Remove dist
mattch1 Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/services/overseas-entities/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,9 @@ export default class OverseasEntityService {

public async postOverseasEntity (
transactionId: string,
body: OverseasEntity,
isSaveAndResumeFeatureActive: boolean = false
body: OverseasEntity
Copy link
Contributor

@markpit markpit Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the isSaveAndResumeFeatureActive will still be needed for the update journey, this function is called by createOverseasEntity in overseas.entities.service which is used by update.filing.date.controller among other things.

Copy link
Contributor

@markpit markpit Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, if that flag is needed then the endpoint will be, so if we are removing the old /start endpoint then the update s & r feature flags will have to be removed from the web as well as there will be no way to save the data all in one go. So looks like we may have to get confirmation from kainos that we can remove their feature flag too.

): Promise<Resource<OverseasEntityCreated> | ApiErrorResponse> {
const URL = (isSaveAndResumeFeatureActive)
? `/transactions/${transactionId}/overseas-entity/start`
: `/transactions/${transactionId}/overseas-entity`;
const URL = `/transactions/${transactionId}/overseas-entity`;
const response: HttpResponse = await this.client.httpPost(URL, mapOverseasEntity(body));

if (response.error) {
Expand Down