Dont interpolate removed text nodes#158
Open
yanatan16 wants to merge 4 commits intocomponent:masterfrom
Open
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In IE9, accessing a DOM Text Node's value results in an error (
Invalid Argument).When elements are removed from the DOM, we still might process them in the
_bindstage, which is OK because side effects are possible (although probably not a good idea). However, DOM Text Nodes can have no side effects so they are safe to remove from processing.A test has been added that passes, and the tests involving
input.type == 'email'have been edited to usegetAttributeandsetAttributebecause IE9 doesnt support those input types, so it just returns'text'. Tests now pass in IE9