fix(tokens,store,indexer,soroban): fix approveAllowance parameter ord… - #437
Merged
Jaydbrown merged 1 commit intoAug 31, 2026
Conversation
…er, dismiss in-flight toasts on disconnect, parallelize indexer stream fetching, and scope circuit breaker
|
@Prudentdev-xyz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…er, dismiss in-flight toasts on disconnect, parallelize indexer stream fetching, and scope circuit breaker
What does this PR do?
Type of change
Related issue
approveAllowanceplaces the requiredsignTxparameter after the defaultedexpirationLedger, making the default unreachable #385- Closes Bug:
clearTransactions()wipes the store but nevertoast.dismiss()s in-flight loading toasts — they persist forever after wallet disconnect #386- Closes
fetchStreamsFromIndexer— sequential N+1 RPC that silently drops failed streams #342- Closes Circuit-breaker state in
lib/soroban.tsis module-global and never reset #344Changes
Checklist
npm run typecheck— no errorsnpm run lint— no warningsnpm test— all tests passnpm run build— production build succeedsalert())'use client'added only where genuinely neededCHANGELOG.mdupdated under[Unreleased]Screenshots
Notes for reviewers